From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ross Lagerwall <ross.lagerwall@citrix.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com,
mpohlack@amazon.com, stefano.stabellini@citrix.com,
jbeulich@suse.com, sasha.levin@oracle.com,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 07/13] xsplice: Add helper elf routines (v2)
Date: Fri, 5 Feb 2016 13:38:00 -0500 [thread overview]
Message-ID: <20160205183800.GC26294@x230.dumpdata.com> (raw)
In-Reply-To: <569E491D.2070207@citrix.com>
> >+#define return_(x) { printk(XENLOG_DEBUG "%s:%d rc: %d\n", \
> >+ __func__,__LINE__, x); return x; }
> >+
.. snip..
> >+ printk(XENLOG_ERR "Could not allocate memory for section table!\n");
>
> Shouldn't this printk be removed if you're using return_?
I was torn on the return_ macro. At one hand it helps to identify what
went wrong with the payload file. But at the same time it is very
developer-centric - so perhaps not to be in the final piece.
And yes, if we do want to go ahead with the return_ macro, then this
should go away.
next prev parent reply other threads:[~2016-02-05 18:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 21:46 [PATCH v2] xSplice v1 implementation Konrad Rzeszutek Wilk
2016-01-14 21:46 ` [PATCH v2 01/13] xsplice: Design document (v5) Konrad Rzeszutek Wilk
2016-01-19 11:14 ` Wei Liu
2016-01-19 14:31 ` Ross Lagerwall
2016-02-05 18:27 ` Konrad Rzeszutek Wilk
2016-02-05 18:34 ` Konrad Rzeszutek Wilk
2016-02-05 15:25 ` Jan Beulich
2016-02-05 21:47 ` Konrad Rzeszutek Wilk
2016-02-09 8:25 ` Jan Beulich
2016-01-14 21:47 ` [PATCH v2 02/13] hypervisor/arm/keyhandler: Declare struct cpu_user_regs; Konrad Rzeszutek Wilk
2016-01-14 21:47 ` [PATCH v2 03/13] xen/xsplice: Hypervisor implementation of XEN_XSPLICE_op (v7) Konrad Rzeszutek Wilk
2016-01-19 14:30 ` Ross Lagerwall
2016-02-06 22:35 ` Doug Goldstein
2016-02-09 8:28 ` Jan Beulich
2016-02-09 14:39 ` Konrad Rzeszutek Wilk
2016-01-14 21:47 ` [PATCH v2 04/13] libxc: Implementation of XEN_XSPLICE_op in libxc (v4) Konrad Rzeszutek Wilk
2016-01-19 11:14 ` Wei Liu
2016-01-14 21:47 ` [PATCH v2 05/13] xen-xsplice: Tool to manipulate xsplice payloads (v3) Konrad Rzeszutek Wilk
2016-01-19 11:14 ` Wei Liu
2016-01-19 14:30 ` Ross Lagerwall
2016-01-14 21:47 ` [PATCH v2 06/13] elf: Add relocation types to elfstructs.h Konrad Rzeszutek Wilk
2016-01-14 21:47 ` [PATCH v2 07/13] xsplice: Add helper elf routines (v2) Konrad Rzeszutek Wilk
2016-01-19 14:33 ` Ross Lagerwall
2016-02-05 18:38 ` Konrad Rzeszutek Wilk [this message]
2016-02-05 20:34 ` Konrad Rzeszutek Wilk
2016-01-14 21:47 ` [PATCH v2 08/13] xsplice: Implement payload loading (v2) Konrad Rzeszutek Wilk
2016-01-19 14:34 ` Ross Lagerwall
2016-01-19 16:59 ` Konrad Rzeszutek Wilk
2016-01-25 11:21 ` Ross Lagerwall
2016-01-19 16:45 ` Ross Lagerwall
2016-01-14 21:47 ` [PATCH v2 09/13] xsplice: Implement support for applying/reverting/replacing patches. (v2) Konrad Rzeszutek Wilk
2016-01-19 14:39 ` Ross Lagerwall
2016-01-19 16:55 ` Konrad Rzeszutek Wilk
2016-01-25 11:43 ` Ross Lagerwall
2016-02-05 19:30 ` Konrad Rzeszutek Wilk
2016-01-14 21:47 ` [PATCH v2 10/13] xen_hello_world.xsplice: Test payload for patching 'xen_extra_version' Konrad Rzeszutek Wilk
2016-01-19 11:14 ` Wei Liu
2016-01-19 14:57 ` Ross Lagerwall
2016-01-19 16:47 ` Ross Lagerwall
2016-01-14 21:47 ` [PATCH v2 11/13] xsplice: Add support for bug frames. (v2) Konrad Rzeszutek Wilk
2016-01-19 14:42 ` Ross Lagerwall
2016-01-14 21:47 ` [PATCH v2 12/13] xsplice: Add support for exception tables. (v2) Konrad Rzeszutek Wilk
2016-01-14 21:47 ` [PATCH v2 13/13] xsplice: Add support for alternatives Konrad Rzeszutek Wilk
2016-01-15 16:58 ` [PATCH v2] xSplice v1 implementation Konrad Rzeszutek Wilk
2016-01-25 11:57 ` Ross Lagerwall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205183800.GC26294@x230.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=mpohlack@amazon.com \
--cc=ross.lagerwall@citrix.com \
--cc=sasha.levin@oracle.com \
--cc=stefano.stabellini@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).