From: Dario Faggioli <dario.faggioli@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
George Dunlap <george.dunlap@citrix.com>
Subject: [PATCH] xl: use bool type for flags instead of int
Date: Sat, 06 Feb 2016 03:00:52 +0100 [thread overview]
Message-ID: <20160206020052.6436.89943.stgit@Solace.station> (raw)
in schedulers' command handlers.
No functional change intended.
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: George Dunlap <george.dunlap@citrix.com>
---
tools/libxl/xl_cmdimpl.c | 27 +++++++++++++++------------
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 20704d2..d07ccb2 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -6035,9 +6035,11 @@ int main_sched_credit(int argc, char **argv)
{
const char *dom = NULL;
const char *cpupool = NULL;
- int weight = 256, cap = 0, opt_w = 0, opt_c = 0;
- int opt_s = 0;
- int tslice = 0, opt_t = 0, ratelimit = 0, opt_r = 0;
+ int weight = 256, cap = 0;
+ int tslice = 0, ratelimit = 0;
+ bool opt_w = false, opt_c = false;
+ bool opt_t = false, opt_r = false;
+ bool opt_s = false;
int opt, rc;
static struct option opts[] = {
{"domain", 1, 0, 'd'},
@@ -6056,22 +6058,22 @@ int main_sched_credit(int argc, char **argv)
break;
case 'w':
weight = strtol(optarg, NULL, 10);
- opt_w = 1;
+ opt_w = true;
break;
case 'c':
cap = strtol(optarg, NULL, 10);
- opt_c = 1;
+ opt_c = true;
break;
case 't':
tslice = strtol(optarg, NULL, 10);
- opt_t = 1;
+ opt_t = true;
break;
case 'r':
ratelimit = strtol(optarg, NULL, 10);
- opt_r = 1;
+ opt_r = true;
break;
case 's':
- opt_s = 1;
+ opt_s = true;
break;
case 'p':
cpupool = optarg;
@@ -6157,7 +6159,8 @@ int main_sched_credit2(int argc, char **argv)
{
const char *dom = NULL;
const char *cpupool = NULL;
- int weight = 256, opt_w = 0;
+ int weight = 256;
+ bool opt_w = false;
int opt, rc;
static struct option opts[] = {
{"domain", 1, 0, 'd'},
@@ -6172,7 +6175,7 @@ int main_sched_credit2(int argc, char **argv)
break;
case 'w':
weight = strtol(optarg, NULL, 10);
- opt_w = 1;
+ opt_w = true;
break;
case 'p':
cpupool = optarg;
@@ -6246,11 +6249,11 @@ int main_sched_rtds(int argc, char **argv)
break;
case 'p':
period = strtol(optarg, NULL, 10);
- opt_p = 1;
+ opt_p = true;
break;
case 'b':
budget = strtol(optarg, NULL, 10);
- opt_b = 1;
+ opt_b = true;
break;
case 'c':
cpupool = optarg;
next reply other threads:[~2016-02-06 2:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 2:00 Dario Faggioli [this message]
2016-02-08 10:21 ` [PATCH] xl: use bool type for flags instead of int George Dunlap
2016-02-08 15:45 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160206020052.6436.89943.stgit@Solace.station \
--to=dario.faggioli@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).