From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v3 2/5] arm/config: Declare ELFSIZE_[32|64] respectively. Date: Fri, 12 Feb 2016 10:56:42 -0500 Message-ID: <20160212155642.GC28574@char.us.oracle.com> References: <1455246507-5589-1-git-send-email-konrad.wilk@oracle.com> <1455246507-5589-3-git-send-email-konrad.wilk@oracle.com> <20160212141753.GC6596@localhost.localdomain> <56BE027802000078000D1765@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aUG5S-0005Mr-GW for xen-devel@lists.xenproject.org; Fri, 12 Feb 2016 15:56:50 +0000 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Fri, Feb 12, 2016 at 03:26:14PM +0000, Stefano Stabellini wrote: > On Fri, 12 Feb 2016, Jan Beulich wrote: > > >>> On 12.02.16 at 15:17, wrote: > > > --- a/xen/include/asm-arm/config.h > > > +++ b/xen/include/asm-arm/config.h > > > @@ -15,8 +15,10 @@ > > > > > > #if defined(CONFIG_ARM_64) > > > # define LONG_BYTEORDER 3 > > > +# define ELFSIZE 64 > > > #else > > > # define LONG_BYTEORDER 2 > > > +# define ELFSIZE 64 > > > #endif > > > > Leaving the question - why twice instead of outside the #ifdef? > > Right, please move it out of the #ifdef. Done! >>From 32a062c119091f2f3f6a4c540a8098e97c273dd2 Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Fri, 5 Feb 2016 10:44:45 -0500 Subject: [PATCH] arm/config: Declare ELFSIZE_64. Otherwise any code that tries to use Elf_* macros would require us to use Elf64_* types instead of the more friendly Elf_ one. This is OK to do since 32-bit ARM uses LPAE mode. CC: ian.campbell@citrix.com CC: wei.liu2@citrix.com CC: stefano.stabellini@citrix.com Signed-off-by: Konrad Rzeszutek Wilk --- xen/include/asm-arm/config.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h index bd832df..a1b968d 100644 --- a/xen/include/asm-arm/config.h +++ b/xen/include/asm-arm/config.h @@ -25,6 +25,9 @@ /* xen_ulong_t is always 64 bits */ #define BITS_PER_XEN_ULONG 64 +/* And ELF files are also 64-bit. */ +#define ELFSIZE 64 + #define CONFIG_PAGING_ASSISTANCE 1 #define CONFIG_PAGING_LEVELS 3 -- 2.1.0