From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v3 2/5] arm/config: Declare ELFSIZE_[32|64]
	respectively.
Date: Fri, 12 Feb 2016 12:50:48 -0500
Message-ID: <20160212175048.GD10110@char.us.oracle.com>
References: <1455246507-5589-1-git-send-email-konrad.wilk@oracle.com>
	<1455246507-5589-3-git-send-email-konrad.wilk@oracle.com>
	<alpine.DEB.2.02.1602121120450.27008@kaball.uk.xensource.com>
	<20160212141753.GC6596@localhost.localdomain>
	<56BE027802000078000D1765@prv-mh.provo.novell.com>
	<alpine.DEB.2.02.1602121524190.27008@kaball.uk.xensource.com>
	<20160212155642.GC28574@char.us.oracle.com>
	<alpine.DEB.2.02.1602121556590.27008@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <konrad@char.us.oracle.com>) id 1aUHrr-0005C7-KA
	for xen-devel@lists.xenproject.org; Fri, 12 Feb 2016 17:50:55 +0000
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.02.1602121556590.27008@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, Jan Beulich <JBeulich@suse.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Fri, Feb 12, 2016 at 03:57:25PM +0000, Stefano Stabellini wrote:
> On Fri, 12 Feb 2016, Konrad Rzeszutek Wilk wrote:
> > On Fri, Feb 12, 2016 at 03:26:14PM +0000, Stefano Stabellini wrote:
> > > On Fri, 12 Feb 2016, Jan Beulich wrote:
> > > > >>> On 12.02.16 at 15:17, <konrad.wilk@oracle.com> wrote:
> > > > > --- a/xen/include/asm-arm/config.h
> > > > > +++ b/xen/include/asm-arm/config.h
> > > > > @@ -15,8 +15,10 @@
> > > > >  
> > > > >  #if defined(CONFIG_ARM_64)
> > > > >  # define LONG_BYTEORDER 3
> > > > > +# define ELFSIZE 64
> > > > >  #else
> > > > >  # define LONG_BYTEORDER 2
> > > > > +# define ELFSIZE 64
> > > > >  #endif
> > > > 
> > > > Leaving the question - why twice instead of outside the #ifdef?
> > > 
> > > Right, please move it out of the #ifdef.
> > 
> > Done!
> > 
> > >From 32a062c119091f2f3f6a4c540a8098e97c273dd2 Mon Sep 17 00:00:00 2001
> > From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Date: Fri, 5 Feb 2016 10:44:45 -0500
> > Subject: [PATCH] arm/config: Declare ELFSIZE_64.
> > 
> > Otherwise any code that tries to use Elf_* macros would
> > require us to use Elf64_* types instead of the more
> > friendly Elf_ one.
> > 
> > This is OK to do since 32-bit ARM uses LPAE mode.
> > 
> > CC: ian.campbell@citrix.com
> > CC: wei.liu2@citrix.com
> > CC: stefano.stabellini@citrix.com
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

applied. Thanks!
> 
> 
> >  xen/include/asm-arm/config.h | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
> > index bd832df..a1b968d 100644
> > --- a/xen/include/asm-arm/config.h
> > +++ b/xen/include/asm-arm/config.h
> > @@ -25,6 +25,9 @@
> >  /* xen_ulong_t is always 64 bits */
> >  #define BITS_PER_XEN_ULONG 64
> >  
> > +/* And ELF files are also 64-bit. */
> > +#define ELFSIZE 64
> > +
> >  #define CONFIG_PAGING_ASSISTANCE 1
> >  
> >  #define CONFIG_PAGING_LEVELS 3
> > -- 
> > 2.1.0
> >