From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH V3] vm_event: Remove xc_mem_access_enable_emulate() and friends Date: Mon, 15 Feb 2016 11:34:25 +0000 Message-ID: <20160215113425.GG8818@citrix.com> References: <1455439138-19093-1-git-send-email-rcojocaru@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1455439138-19093-1-git-send-email-rcojocaru@bitdefender.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Razvan Cojocaru Cc: tamas@tklengyel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, jbeulich@suse.com, keir@xen.org List-Id: xen-devel@lists.xenproject.org On Sun, Feb 14, 2016 at 10:38:58AM +0200, Razvan Cojocaru wrote: > xc_mem_access_enable_emulate() and xc_mem_access_disable_emulate() > are currently no-ops, that is all they do is set a flag that > nobody else checks. The user can already set the EMULATE flags in > the vm_event response if emulation is desired, and having an extra > check above that is not inherently safer, but it does complicate > (currenly unnecessarily) the API. This patch removes these > functions and the corresponding hypervisor code. > > Signed-off-by: Razvan Cojocaru > > --- > Changes since V1: > - Commented-out the XENMEM_access_op_enable_emulate and > XENMEM_access_op_disable_emulate #defines instead of simply > removing them to prevent their reuse, as requested by > Jan Beulich. > --- > tools/libxc/include/xenctrl.h | 11 ----------- > tools/libxc/xc_mem_access.c | 24 ------------------------ Acked-by: Wei Liu