From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Tommi Airikka <tommi@airikka.net>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, david.vrabel@citrix.com
Subject: Re: [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted.
Date: Mon, 15 Feb 2016 09:05:32 -0500 [thread overview]
Message-ID: <20160215140532.GB3698@char.us.oracle.com> (raw)
In-Reply-To: <56BFD702.9010708@oracle.com>
On Sat, Feb 13, 2016 at 08:23:14PM -0500, Boris Ostrovsky wrote:
> On 02/11/2016 04:10 PM, Konrad Rzeszutek Wilk wrote:
> >
> >This patch fixes the issue by:
> > 1) Use kzalloc to initialize to a well known state.
> > 2) Put 'struct pci_sysdata' at the start of 'pcifront_sd'. That
> > way access to the 'node' will access the right offset.
> >
> >CC: stable@vger.kernel.org
> >Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>
> (This, btw, is the second time we got bitten by pcifront_sd bit not being
> pci_sysdata. dc4fdaf0e48 was a workaround for a similar problem and we
> should have fixed it then).
I think that the dc4fdaf0e4839109169d8261814813816951c75f commit can be
reverted then?
Ah no, b/c:
" Fixes: 97badf873ab6 (device property: Make it possible to use secondary firmware nodes)"
>
> -boris
next prev parent reply other threads:[~2016-02-15 14:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 21:10 [PATCH] Fixes to Xen pcifront and pciback (v1) Konrad Rzeszutek Wilk
2016-02-11 21:10 ` [PATCH 1/4] xen/pciback: Check PF instead of VF for PCI_COMMAND_MEMORY Konrad Rzeszutek Wilk
2016-02-12 9:19 ` Jan Beulich
2016-02-11 21:10 ` [PATCH 2/4] xen/pciback: Save the number of MSI-X entries to be copied later Konrad Rzeszutek Wilk
2016-02-12 9:25 ` Jan Beulich
2016-02-11 21:10 ` [PATCH 3/4] xen/pcifront: Report the errors better Konrad Rzeszutek Wilk
2016-02-11 21:10 ` [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted Konrad Rzeszutek Wilk
2016-02-14 1:23 ` Boris Ostrovsky
[not found] ` <56BFD702.9010708@oracle.com>
2016-02-15 14:05 ` Konrad Rzeszutek Wilk [this message]
2016-02-15 14:37 ` Boris Ostrovsky
2016-02-15 14:27 ` David Vrabel
2016-02-15 14:35 ` [PATCH] Fixes to Xen pcifront and pciback (v1) David Vrabel
[not found] ` <56C1E24C.5040704@citrix.com>
2016-02-15 14:38 ` David Vrabel
[not found] ` <56C1E2DE.7030507@citrix.com>
2016-02-15 15:35 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215140532.GB3698@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tommi@airikka.net \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).