From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted. Date: Mon, 15 Feb 2016 09:05:32 -0500 Message-ID: <20160215140532.GB3698@char.us.oracle.com> References: <1455225026-25792-1-git-send-email-konrad.wilk@oracle.com> <1455225026-25792-5-git-send-email-konrad.wilk@oracle.com> <56BFD702.9010708@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVJmV-0007bv-Ps for xen-devel@lists.xenproject.org; Mon, 15 Feb 2016 14:05:39 +0000 Content-Disposition: inline In-Reply-To: <56BFD702.9010708@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: Tommi Airikka , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, david.vrabel@citrix.com List-Id: xen-devel@lists.xenproject.org On Sat, Feb 13, 2016 at 08:23:14PM -0500, Boris Ostrovsky wrote: > On 02/11/2016 04:10 PM, Konrad Rzeszutek Wilk wrote: > > > >This patch fixes the issue by: > > 1) Use kzalloc to initialize to a well known state. > > 2) Put 'struct pci_sysdata' at the start of 'pcifront_sd'. That > > way access to the 'node' will access the right offset. > > > >CC: stable@vger.kernel.org > >Signed-off-by: Konrad Rzeszutek Wilk > > Reviewed-by: Boris Ostrovsky > > (This, btw, is the second time we got bitten by pcifront_sd bit not being > pci_sysdata. dc4fdaf0e48 was a workaround for a similar problem and we > should have fixed it then). I think that the dc4fdaf0e4839109169d8261814813816951c75f commit can be reverted then? Ah no, b/c: " Fixes: 97badf873ab6 (device property: Make it possible to use secondary firmware nodes)" > > -boris