From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Tommi Airikka <tommi@airikka.net>,
xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixes to Xen pcifront and pciback (v1)
Date: Mon, 15 Feb 2016 10:35:35 -0500 [thread overview]
Message-ID: <20160215153535.GB4177@char.us.oracle.com> (raw)
In-Reply-To: <56C1E2DE.7030507@citrix.com>
On Mon, Feb 15, 2016 at 02:38:22PM +0000, David Vrabel wrote:
> On 15/02/16 14:35, David Vrabel wrote:
> > On 11/02/16 21:10, Konrad Rzeszutek Wilk wrote:
> >> Hey,
> >>
> >> These are patches that were developed for the Debian bug
> >> 810379 which san Tommi had openned.
> >>
> >> The issue around from the two XSA fixes - which introduced
> >> this regression.
> >
> > Applied to for-linus-4.6, thanks.
>
> I mean for-linus-4.5.
Thanks!
>
> I also fixed the minor style quibbles.
Thank you. It was written rather hurriedly.
>
> David
>
> > I rewrote some of the commit messages for clarity. Please only put
> > relevant information in them and for regression fixes, make sure it's
> > clear what functionality regressed.
> >
> > e.g. #1 now reads:
> >
> > Commit 408fb0e5aa7fda0059db282ff58c3b2a4278baa0 (xen/pciback: Don't
> > allow MSI-X ops if PCI_COMMAND_MEMORY is not set) prevented enabling
> > MSI-X on passed-through virtual functions, because it checked the VF
> > for PCI_COMMAND_MEMORY but this is not a valid bit for VFs.
> >
> > Instead, check the physical function for PCI_COMMAND_MEMORY.
> >
> > David
> >
>
prev parent reply other threads:[~2016-02-15 15:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 21:10 [PATCH] Fixes to Xen pcifront and pciback (v1) Konrad Rzeszutek Wilk
2016-02-11 21:10 ` [PATCH 1/4] xen/pciback: Check PF instead of VF for PCI_COMMAND_MEMORY Konrad Rzeszutek Wilk
2016-02-12 9:19 ` Jan Beulich
2016-02-11 21:10 ` [PATCH 2/4] xen/pciback: Save the number of MSI-X entries to be copied later Konrad Rzeszutek Wilk
2016-02-12 9:25 ` Jan Beulich
2016-02-11 21:10 ` [PATCH 3/4] xen/pcifront: Report the errors better Konrad Rzeszutek Wilk
2016-02-11 21:10 ` [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted Konrad Rzeszutek Wilk
2016-02-14 1:23 ` Boris Ostrovsky
[not found] ` <56BFD702.9010708@oracle.com>
2016-02-15 14:05 ` Konrad Rzeszutek Wilk
2016-02-15 14:37 ` Boris Ostrovsky
2016-02-15 14:27 ` David Vrabel
2016-02-15 14:35 ` [PATCH] Fixes to Xen pcifront and pciback (v1) David Vrabel
[not found] ` <56C1E24C.5040704@citrix.com>
2016-02-15 14:38 ` David Vrabel
[not found] ` <56C1E2DE.7030507@citrix.com>
2016-02-15 15:35 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215153535.GB4177@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tommi@airikka.net \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).