From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] Fixes to Xen pcifront and pciback (v1) Date: Mon, 15 Feb 2016 10:35:35 -0500 Message-ID: <20160215153535.GB4177@char.us.oracle.com> References: <1455225026-25792-1-git-send-email-konrad.wilk@oracle.com> <56C1E24C.5040704@citrix.com> <56C1E2DE.7030507@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVLBj-0006Xl-66 for xen-devel@lists.xenproject.org; Mon, 15 Feb 2016 15:35:47 +0000 Content-Disposition: inline In-Reply-To: <56C1E2DE.7030507@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel Cc: Tommi Airikka , xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org On Mon, Feb 15, 2016 at 02:38:22PM +0000, David Vrabel wrote: > On 15/02/16 14:35, David Vrabel wrote: > > On 11/02/16 21:10, Konrad Rzeszutek Wilk wrote: > >> Hey, > >> > >> These are patches that were developed for the Debian bug > >> 810379 which san Tommi had openned. > >> > >> The issue around from the two XSA fixes - which introduced > >> this regression. > > > > Applied to for-linus-4.6, thanks. > > I mean for-linus-4.5. Thanks! > > I also fixed the minor style quibbles. Thank you. It was written rather hurriedly. > > David > > > I rewrote some of the commit messages for clarity. Please only put > > relevant information in them and for regression fixes, make sure it's > > clear what functionality regressed. > > > > e.g. #1 now reads: > > > > Commit 408fb0e5aa7fda0059db282ff58c3b2a4278baa0 (xen/pciback: Don't > > allow MSI-X ops if PCI_COMMAND_MEMORY is not set) prevented enabling > > MSI-X on passed-through virtual functions, because it checked the VF > > for PCI_COMMAND_MEMORY but this is not a valid bit for VFs. > > > > Instead, check the physical function for PCI_COMMAND_MEMORY. > > > > David > > >