From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 01/14] xen: sched: __runq_tickle takes a useless cpu parameter Date: Mon, 15 Feb 2016 11:14:34 -0500 Message-ID: <20160215161434.GA4697@char.us.oracle.com> References: <20160205183137.4543.56523.stgit@Solace.station> <20160205183334.4543.50511.stgit@Solace.station> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVLnN-0001b3-Sl for xen-devel@lists.xenproject.org; Mon, 15 Feb 2016 16:14:41 +0000 Content-Disposition: inline In-Reply-To: <20160205183334.4543.50511.stgit@Solace.station> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: xen-devel@lists.xenproject.org, George Dunlap List-Id: xen-devel@lists.xenproject.org On Fri, Feb 05, 2016 at 07:33:34PM +0100, Dario Faggioli wrote: > as it is always acts on v->processor of the vcpu because > of which we are tickling. s/because of which// ? > > Getting rid of it makes the code easier to understand > and better looking. > > While there, remove a spurious blank line. > Reviewed-by: Konrad Rzeszutek Wilk > Signed-off-by: Dario Faggioli > --- > Cc: George Dunlap > --- > xen/common/sched_credit.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c > index 671bbee..5279b92 100644 > --- a/xen/common/sched_credit.c > +++ b/xen/common/sched_credit.c > @@ -360,9 +360,9 @@ boolean_param("tickle_one_idle_cpu", opt_tickle_one_idle); > > DEFINE_PER_CPU(unsigned int, last_tickle_cpu); > > -static inline void > -__runq_tickle(unsigned int cpu, struct csched_vcpu *new) > +static inline void __runq_tickle(struct csched_vcpu *new) > { > + unsigned int cpu = new->vcpu->processor; > struct csched_vcpu * const cur = CSCHED_VCPU(curr_on_cpu(cpu)); > struct csched_private *prv = CSCHED_PRIV(per_cpu(scheduler, cpu)); > cpumask_t mask, idle_mask, *online; > @@ -375,7 +375,6 @@ __runq_tickle(unsigned int cpu, struct csched_vcpu *new) > cpumask_and(&idle_mask, prv->idlers, online); > idlers_empty = cpumask_empty(&idle_mask); > > - > /* > * If the pcpu is idle, or there are no idlers and the new > * vcpu is a higher priority than the old vcpu, run it here. > @@ -980,11 +979,10 @@ static void > csched_vcpu_wake(const struct scheduler *ops, struct vcpu *vc) > { > struct csched_vcpu * const svc = CSCHED_VCPU(vc); > - const unsigned int cpu = vc->processor; > > BUG_ON( is_idle_vcpu(vc) ); > > - if ( unlikely(curr_on_cpu(cpu) == vc) ) > + if ( unlikely(curr_on_cpu(vc->processor) == vc) ) > { > SCHED_STAT_CRANK(vcpu_wake_running); > return; > @@ -1028,7 +1026,7 @@ csched_vcpu_wake(const struct scheduler *ops, struct vcpu *vc) > > /* Put the VCPU on the runq and tickle CPUs */ > __runq_insert(svc); > - __runq_tickle(cpu, svc); > + __runq_tickle(svc); > } > > static void > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel