From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: git workflow and http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches Date: Mon, 15 Feb 2016 16:21:28 +0000 Message-ID: <20160215162127.GB11740@citrix.com> References: <20160215160057.GA4308@char.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160215160057.GA4308@char.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xensource.com, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, Feb 15, 2016 at 11:00:58AM -0500, Konrad Rzeszutek Wilk wrote: > Hey, > > I wanted to ask what folks would think of expanding the Wiki to include (making it a diff > for simpler) this change. With my giant 30 set of patches that not only CC-ed > xen-devel twice but had some patches CC some maintainers but not others - I figured > it may be good to describe this in the Wiki: > > --- orig 2016-02-15 10:45:27.719204371 -0500 > +++ new 2016-02-15 10:58:33.113755665 -0500 > @@ -140,7 +140,35 @@ > * The maintainers are listed in the MAINTAINERS file at the top of the Xen source tree. If no maintainer is listed then there is no need for a CC (if you are modifying code with no maintainer then you might like to consider becoming the maintainer for that piece of code!). > ** You can pipe your patch to the ./scripts/get_maintainer.pl tool and it will list the relevant maintainers. > * In addition to CCing the maintainer you should always send patches to (via TO) the xen-devel@lists.xenproject.org mailing list as well. > -* To add a CC when sending the mail you can use the ''--cc'' option to the ''git send-email'' command, or you can do it manually in your MUA. > +* To add a CC when sending the mail you can: > + * use the ''--cc'' option to the ''git send-email'' command - however if your > + patchset is to multiple maintainers - you may end up sending all of the > + patches to all maintainers - where some of them have no interest in > + viewing them (as they are not under their responsibility). > + * edit each patch to have the proper maintainer on the CC list by adding: > +
> +CC: joe@doe.com
> +
> + in the patch. > + * or alternatively use --cc-cmd in your .gitconfig: I wouldn't encourage people to put this in their global gitconfig file. It either needs to be in project local gitconfig .git/config or be spelled out explicitly in command line. Wei. > +
> +[sendemail]
> +    cc-cmd = scripts/get_maintainer.pl --remove-duplicates --no-l
> +
> +which will automatically add the proper maintainer on the CC line. > +The ''no-l'' is to not add the mailing list to the CC (as you would > +be adding that via the TO - see above) > + * or you can do it manually in your MUA. > + > +In short, it could look like this: > +
> +$pwd
> +/home/joedoe/xen
> +git send-email --to xen-devel@lists.xenproject.org --to jo@doe.com --compose --subject "[PATCH v1] Fixes to frobnicator." *.patch
> +
> + > +Which will send all patches to yourself on the TO, to xen-devel mailiing list (on the TO:) > +and the patches will have their CC: list generated based on scripts/get_maintainer.pl. > > === Providing a git branch === > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel