From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 03/14] xen: sched: fi position of TRC_SCHED_DOM_{ADD, REM} Date: Mon, 15 Feb 2016 11:41:58 -0500 Message-ID: <20160215164158.GI4697@char.us.oracle.com> References: <20160205183137.4543.56523.stgit@Solace.station> <20160205183349.4543.23589.stgit@Solace.station> <20160215162205.GC4697@char.us.oracle.com> <1455554225.14334.57.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVMDs-00057E-CI for xen-devel@lists.xenproject.org; Mon, 15 Feb 2016 16:42:04 +0000 Content-Disposition: inline In-Reply-To: <1455554225.14334.57.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: George Dunlap , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Mon, Feb 15, 2016 at 05:37:05PM +0100, Dario Faggioli wrote: > On Mon, 2016-02-15 at 11:22 -0500, Konrad Rzeszutek Wilk wrote: > > On Fri, Feb 05, 2016 at 07:33:50PM +0100, Dario Faggioli wrote: > > > > On the title you have 'fi', but I think you meant 'fix'. > > > Indeed, sorry for that. > > > > so that they actually live in the functions that > > > do the scheduling related domain initialization and > > > destruction. > > > > > > Signed-off-by: Dario Faggioli > > > > .. would it make sense to have an overall high-level > > 'DOM_ADD' and 'DOM_REM' trace ? > > > > Especially as it is useful for figuring out how long > > an domain destruction takes time (based on the initial > > trace to say this TRC_SCHED_REM)? > > > I think it makes sense, and I can either do this in this patch (and > resend) or as a follow up. > > I guess the only possible concern is that we may introduce too much > tracing, to the point that it hurts performance, even when not enabled. .. How often do we do these operations? > (I was starting to think about this anyway, as I've got other series, > either posted or in my queues, that adds a few more tracepoints, > because they're so damn useful! ;-P) > > In that case, I guess we could think of doing something similar to what > ftrace does in Linux --for disabling and enabling tracing and > tracepoints-- which should be more lightweight than what we do. > > In any case, none of this applies to a "DOM_ADD" / "DOM_REM" tracing > events. :-) Correct. This patch does fix the mis-use of the trace points. > > Thanks and Regards, > Dario > > -- > <> (Raistlin Majere) > ----------------------------------------------------------------- > Dario Faggioli, Ph.D, http://about.me/dario.faggioli > Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) >