* [PATCH] xen-blkback: advertise indirect segment support earlier
@ 2016-02-10 11:18 Jan Beulich
2016-02-10 12:27 ` Roger Pau Monné
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2016-02-10 11:18 UTC (permalink / raw)
To: Roger Pau Monne, Konrad Rzeszutek Wilk; +Cc: xen-devel
There's no reason to defer this until the connect phase, and in fact
there are frontend implementations expecting this to be available
earlier. Move it into the probe function.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Bob Liu <bob.liu@oracle.com>
---
drivers/block/xen-blkback/xenbus.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
--- 4.5-rc3/drivers/block/xen-blkback/xenbus.c
+++ 4.5-rc3-xen-blkback-ind-descr-advertise/drivers/block/xen-blkback/xenbus.c
@@ -618,6 +618,14 @@ static int xen_blkbk_probe(struct xenbus
goto fail;
}
+ err = xenbus_printf(XBT_NIL, dev->nodename,
+ "feature-max-indirect-segments", "%u",
+ MAX_INDIRECT_SEGMENTS);
+ if (err)
+ dev_warn(&dev->dev,
+ "writing %s/feature-max-indirect-segments (%d)",
+ dev->nodename, err);
+
/* Multi-queue: advertise how many queues are supported by us.*/
err = xenbus_printf(XBT_NIL, dev->nodename,
"multi-queue-max-queues", "%u", xenblk_max_queues);
@@ -849,11 +857,6 @@ again:
dev->nodename);
goto abort;
}
- err = xenbus_printf(xbt, dev->nodename, "feature-max-indirect-segments", "%u",
- MAX_INDIRECT_SEGMENTS);
- if (err)
- dev_warn(&dev->dev, "writing %s/feature-max-indirect-segments (%d)",
- dev->nodename, err);
err = xenbus_printf(xbt, dev->nodename, "sectors", "%llu",
(unsigned long long)vbd_sz(&be->blkif->vbd));
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-blkback: advertise indirect segment support earlier
2016-02-10 11:18 [PATCH] xen-blkback: advertise indirect segment support earlier Jan Beulich
@ 2016-02-10 12:27 ` Roger Pau Monné
2016-02-15 17:39 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 3+ messages in thread
From: Roger Pau Monné @ 2016-02-10 12:27 UTC (permalink / raw)
To: Jan Beulich, Konrad Rzeszutek Wilk; +Cc: xen-devel
El 10/2/16 a les 12:18, Jan Beulich ha escrit:
> There's no reason to defer this until the connect phase, and in fact
> there are frontend implementations expecting this to be available
> earlier. Move it into the probe function.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Looks fine.
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
The same should be done for "feature-persistent" AFAICT.
Roger.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-blkback: advertise indirect segment support earlier
2016-02-10 12:27 ` Roger Pau Monné
@ 2016-02-15 17:39 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 3+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-02-15 17:39 UTC (permalink / raw)
To: Roger Pau Monné; +Cc: xen-devel, Jan Beulich
On Wed, Feb 10, 2016 at 01:27:08PM +0100, Roger Pau Monné wrote:
> El 10/2/16 a les 12:18, Jan Beulich ha escrit:
> > There's no reason to defer this until the connect phase, and in fact
> > there are frontend implementations expecting this to be available
> > earlier. Move it into the probe function.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Looks fine.
>
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
applied.
>
> The same should be done for "feature-persistent" AFAICT.
>
> Roger.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-15 17:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-10 11:18 [PATCH] xen-blkback: advertise indirect segment support earlier Jan Beulich
2016-02-10 12:27 ` Roger Pau Monné
2016-02-15 17:39 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).