From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] stubdom: fix link farm runes
Date: Mon, 15 Feb 2016 20:56:28 +0100 [thread overview]
Message-ID: <20160215195628.GE2697@var.home> (raw)
In-Reply-To: <1455565228-12729-1-git-send-email-wei.liu2@citrix.com>
Wei Liu, on Mon 15 Feb 2016 19:40:28 +0000, wrote:
> Previously in the three problematic libraries all public headers were
> linked to source code directory. We should have created a include
> directory and link headers there.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Indeed, 31d2d1e0 (Move xenstore and libxc public headers to include
subdir) should have done that.
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> stubdom/Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/stubdom/Makefile b/stubdom/Makefile
> index 6f68e98..2044d76 100644
> --- a/stubdom/Makefile
> +++ b/stubdom/Makefile
> @@ -314,9 +314,9 @@ mk-headers-$(XEN_TARGET_ARCH): $(IOEMU_LINKFARM_TARGET)
> ln -sf $(wildcard $(XEN_ROOT)/tools/include/xen-foreign/*) include/xen-foreign/ && \
> $(MAKE) DESTDIR= -C include/xen-foreign/ && \
> ( [ -h include/xen/foreign ] || ln -sf ../xen-foreign include/xen/foreign )
> - mkdir -p libs-$(XEN_TARGET_ARCH)/toollog
> + mkdir -p libs-$(XEN_TARGET_ARCH)/toollog/include
> [ -h libs-$(XEN_TARGET_ARCH)/toollog/Makefile ] || ( cd libs-$(XEN_TARGET_ARCH)/toollog && \
> - ln -sf $(XEN_ROOT)/tools/libs/toollog/include/*.h . && \
> + ln -sf $(XEN_ROOT)/tools/libs/toollog/include/*.h include/ && \
> ln -sf $(XEN_ROOT)/tools/libs/toollog/*.c . && \
> ln -sf $(XEN_ROOT)/tools/libs/toollog/Makefile . )
> mkdir -p libs-$(XEN_TARGET_ARCH)/evtchn/include
> @@ -343,17 +343,17 @@ mk-headers-$(XEN_TARGET_ARCH): $(IOEMU_LINKFARM_TARGET)
> ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/include/*.h include/ && \
> ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/*.c . && \
> ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/Makefile . )
> - mkdir -p libxc-$(XEN_TARGET_ARCH)
> + mkdir -p libxc-$(XEN_TARGET_ARCH)/include
> [ -h libxc-$(XEN_TARGET_ARCH)/Makefile ] || ( cd libxc-$(XEN_TARGET_ARCH) && \
> ln -sf $(XEN_ROOT)/tools/libxc/*.h . && \
> - ln -sf $(XEN_ROOT)/tools/libxc/include/*.h . && \
> + ln -sf $(XEN_ROOT)/tools/libxc/include/*.h include/ && \
> ln -sf $(XEN_ROOT)/tools/libxc/*.c . && \
> ln -sf $(XEN_ROOT)/tools/libxc/Makefile . )
> - mkdir -p xenstore
> + mkdir -p xenstore/include
> [ -h xenstore/Makefile ] || ( cd xenstore && \
> ln -sf $(XEN_ROOT)/tools/xenstore/*.c . && \
> ln -sf $(XEN_ROOT)/tools/xenstore/*.h . && \
> - ln -sf $(XEN_ROOT)/tools/xenstore/include/*.h . && \
> + ln -sf $(XEN_ROOT)/tools/xenstore/include/*.h include/ && \
> ln -sf $(XEN_ROOT)/tools/xenstore/Makefile . )
> $(MAKE) DESTDIR= -C $(MINI_OS) links
> touch mk-headers-$(XEN_TARGET_ARCH)
> --
> 2.1.4
>
--
Samuel
bien sûr que ça convient mieux à tout le monde
enfin, dans la mesure où tout le monde c'est comme moi
-+- le consensus, c'est facile -+-
next prev parent reply other threads:[~2016-02-15 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 19:40 [PATCH] stubdom: fix link farm runes Wei Liu
2016-02-15 19:49 ` Wei Liu
2016-02-15 19:56 ` Samuel Thibault [this message]
2016-02-16 9:10 ` Ian Campbell
2016-02-16 10:29 ` Wei Liu
2016-02-16 12:14 ` Ian Campbell
2016-02-16 12:15 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215195628.GE2697@var.home \
--to=samuel.thibault@ens-lyon.org \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).