* [PATCH] stubdom: fix link farm runes
@ 2016-02-15 19:40 Wei Liu
2016-02-15 19:49 ` Wei Liu
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Wei Liu @ 2016-02-15 19:40 UTC (permalink / raw)
To: Xen-devel
Cc: Ian Jackson, Wei Liu, Ian Campbell, Samuel Thibault,
Stefano Stabellini
Previously in the three problematic libraries all public headers were
linked to source code directory. We should have created a include
directory and link headers there.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
stubdom/Makefile | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/stubdom/Makefile b/stubdom/Makefile
index 6f68e98..2044d76 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -314,9 +314,9 @@ mk-headers-$(XEN_TARGET_ARCH): $(IOEMU_LINKFARM_TARGET)
ln -sf $(wildcard $(XEN_ROOT)/tools/include/xen-foreign/*) include/xen-foreign/ && \
$(MAKE) DESTDIR= -C include/xen-foreign/ && \
( [ -h include/xen/foreign ] || ln -sf ../xen-foreign include/xen/foreign )
- mkdir -p libs-$(XEN_TARGET_ARCH)/toollog
+ mkdir -p libs-$(XEN_TARGET_ARCH)/toollog/include
[ -h libs-$(XEN_TARGET_ARCH)/toollog/Makefile ] || ( cd libs-$(XEN_TARGET_ARCH)/toollog && \
- ln -sf $(XEN_ROOT)/tools/libs/toollog/include/*.h . && \
+ ln -sf $(XEN_ROOT)/tools/libs/toollog/include/*.h include/ && \
ln -sf $(XEN_ROOT)/tools/libs/toollog/*.c . && \
ln -sf $(XEN_ROOT)/tools/libs/toollog/Makefile . )
mkdir -p libs-$(XEN_TARGET_ARCH)/evtchn/include
@@ -343,17 +343,17 @@ mk-headers-$(XEN_TARGET_ARCH): $(IOEMU_LINKFARM_TARGET)
ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/include/*.h include/ && \
ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/*.c . && \
ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/Makefile . )
- mkdir -p libxc-$(XEN_TARGET_ARCH)
+ mkdir -p libxc-$(XEN_TARGET_ARCH)/include
[ -h libxc-$(XEN_TARGET_ARCH)/Makefile ] || ( cd libxc-$(XEN_TARGET_ARCH) && \
ln -sf $(XEN_ROOT)/tools/libxc/*.h . && \
- ln -sf $(XEN_ROOT)/tools/libxc/include/*.h . && \
+ ln -sf $(XEN_ROOT)/tools/libxc/include/*.h include/ && \
ln -sf $(XEN_ROOT)/tools/libxc/*.c . && \
ln -sf $(XEN_ROOT)/tools/libxc/Makefile . )
- mkdir -p xenstore
+ mkdir -p xenstore/include
[ -h xenstore/Makefile ] || ( cd xenstore && \
ln -sf $(XEN_ROOT)/tools/xenstore/*.c . && \
ln -sf $(XEN_ROOT)/tools/xenstore/*.h . && \
- ln -sf $(XEN_ROOT)/tools/xenstore/include/*.h . && \
+ ln -sf $(XEN_ROOT)/tools/xenstore/include/*.h include/ && \
ln -sf $(XEN_ROOT)/tools/xenstore/Makefile . )
$(MAKE) DESTDIR= -C $(MINI_OS) links
touch mk-headers-$(XEN_TARGET_ARCH)
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] stubdom: fix link farm runes
2016-02-15 19:40 [PATCH] stubdom: fix link farm runes Wei Liu
@ 2016-02-15 19:49 ` Wei Liu
2016-02-15 19:56 ` Samuel Thibault
2016-02-16 9:10 ` Ian Campbell
2 siblings, 0 replies; 7+ messages in thread
From: Wei Liu @ 2016-02-15 19:49 UTC (permalink / raw)
To: Xen-devel
Cc: Ian Jackson, Wei Liu, Ian Campbell, Samuel Thibault,
Stefano Stabellini
On Mon, Feb 15, 2016 at 07:40:28PM +0000, Wei Liu wrote:
> Previously in the three problematic libraries all public headers were
> linked to source code directory. We should have created a include
> directory and link headers there.
We should have created an include directory for each library and
linked headers there.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> stubdom/Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/stubdom/Makefile b/stubdom/Makefile
> index 6f68e98..2044d76 100644
> --- a/stubdom/Makefile
> +++ b/stubdom/Makefile
> @@ -314,9 +314,9 @@ mk-headers-$(XEN_TARGET_ARCH): $(IOEMU_LINKFARM_TARGET)
> ln -sf $(wildcard $(XEN_ROOT)/tools/include/xen-foreign/*) include/xen-foreign/ && \
> $(MAKE) DESTDIR= -C include/xen-foreign/ && \
> ( [ -h include/xen/foreign ] || ln -sf ../xen-foreign include/xen/foreign )
> - mkdir -p libs-$(XEN_TARGET_ARCH)/toollog
> + mkdir -p libs-$(XEN_TARGET_ARCH)/toollog/include
> [ -h libs-$(XEN_TARGET_ARCH)/toollog/Makefile ] || ( cd libs-$(XEN_TARGET_ARCH)/toollog && \
> - ln -sf $(XEN_ROOT)/tools/libs/toollog/include/*.h . && \
> + ln -sf $(XEN_ROOT)/tools/libs/toollog/include/*.h include/ && \
> ln -sf $(XEN_ROOT)/tools/libs/toollog/*.c . && \
> ln -sf $(XEN_ROOT)/tools/libs/toollog/Makefile . )
> mkdir -p libs-$(XEN_TARGET_ARCH)/evtchn/include
> @@ -343,17 +343,17 @@ mk-headers-$(XEN_TARGET_ARCH): $(IOEMU_LINKFARM_TARGET)
> ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/include/*.h include/ && \
> ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/*.c . && \
> ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/Makefile . )
> - mkdir -p libxc-$(XEN_TARGET_ARCH)
> + mkdir -p libxc-$(XEN_TARGET_ARCH)/include
> [ -h libxc-$(XEN_TARGET_ARCH)/Makefile ] || ( cd libxc-$(XEN_TARGET_ARCH) && \
> ln -sf $(XEN_ROOT)/tools/libxc/*.h . && \
> - ln -sf $(XEN_ROOT)/tools/libxc/include/*.h . && \
> + ln -sf $(XEN_ROOT)/tools/libxc/include/*.h include/ && \
> ln -sf $(XEN_ROOT)/tools/libxc/*.c . && \
> ln -sf $(XEN_ROOT)/tools/libxc/Makefile . )
> - mkdir -p xenstore
> + mkdir -p xenstore/include
> [ -h xenstore/Makefile ] || ( cd xenstore && \
> ln -sf $(XEN_ROOT)/tools/xenstore/*.c . && \
> ln -sf $(XEN_ROOT)/tools/xenstore/*.h . && \
> - ln -sf $(XEN_ROOT)/tools/xenstore/include/*.h . && \
> + ln -sf $(XEN_ROOT)/tools/xenstore/include/*.h include/ && \
> ln -sf $(XEN_ROOT)/tools/xenstore/Makefile . )
> $(MAKE) DESTDIR= -C $(MINI_OS) links
> touch mk-headers-$(XEN_TARGET_ARCH)
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] stubdom: fix link farm runes
2016-02-15 19:40 [PATCH] stubdom: fix link farm runes Wei Liu
2016-02-15 19:49 ` Wei Liu
@ 2016-02-15 19:56 ` Samuel Thibault
2016-02-16 9:10 ` Ian Campbell
2 siblings, 0 replies; 7+ messages in thread
From: Samuel Thibault @ 2016-02-15 19:56 UTC (permalink / raw)
To: Wei Liu; +Cc: Xen-devel, Ian Jackson, Ian Campbell, Stefano Stabellini
Wei Liu, on Mon 15 Feb 2016 19:40:28 +0000, wrote:
> Previously in the three problematic libraries all public headers were
> linked to source code directory. We should have created a include
> directory and link headers there.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Indeed, 31d2d1e0 (Move xenstore and libxc public headers to include
subdir) should have done that.
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> stubdom/Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/stubdom/Makefile b/stubdom/Makefile
> index 6f68e98..2044d76 100644
> --- a/stubdom/Makefile
> +++ b/stubdom/Makefile
> @@ -314,9 +314,9 @@ mk-headers-$(XEN_TARGET_ARCH): $(IOEMU_LINKFARM_TARGET)
> ln -sf $(wildcard $(XEN_ROOT)/tools/include/xen-foreign/*) include/xen-foreign/ && \
> $(MAKE) DESTDIR= -C include/xen-foreign/ && \
> ( [ -h include/xen/foreign ] || ln -sf ../xen-foreign include/xen/foreign )
> - mkdir -p libs-$(XEN_TARGET_ARCH)/toollog
> + mkdir -p libs-$(XEN_TARGET_ARCH)/toollog/include
> [ -h libs-$(XEN_TARGET_ARCH)/toollog/Makefile ] || ( cd libs-$(XEN_TARGET_ARCH)/toollog && \
> - ln -sf $(XEN_ROOT)/tools/libs/toollog/include/*.h . && \
> + ln -sf $(XEN_ROOT)/tools/libs/toollog/include/*.h include/ && \
> ln -sf $(XEN_ROOT)/tools/libs/toollog/*.c . && \
> ln -sf $(XEN_ROOT)/tools/libs/toollog/Makefile . )
> mkdir -p libs-$(XEN_TARGET_ARCH)/evtchn/include
> @@ -343,17 +343,17 @@ mk-headers-$(XEN_TARGET_ARCH): $(IOEMU_LINKFARM_TARGET)
> ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/include/*.h include/ && \
> ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/*.c . && \
> ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/Makefile . )
> - mkdir -p libxc-$(XEN_TARGET_ARCH)
> + mkdir -p libxc-$(XEN_TARGET_ARCH)/include
> [ -h libxc-$(XEN_TARGET_ARCH)/Makefile ] || ( cd libxc-$(XEN_TARGET_ARCH) && \
> ln -sf $(XEN_ROOT)/tools/libxc/*.h . && \
> - ln -sf $(XEN_ROOT)/tools/libxc/include/*.h . && \
> + ln -sf $(XEN_ROOT)/tools/libxc/include/*.h include/ && \
> ln -sf $(XEN_ROOT)/tools/libxc/*.c . && \
> ln -sf $(XEN_ROOT)/tools/libxc/Makefile . )
> - mkdir -p xenstore
> + mkdir -p xenstore/include
> [ -h xenstore/Makefile ] || ( cd xenstore && \
> ln -sf $(XEN_ROOT)/tools/xenstore/*.c . && \
> ln -sf $(XEN_ROOT)/tools/xenstore/*.h . && \
> - ln -sf $(XEN_ROOT)/tools/xenstore/include/*.h . && \
> + ln -sf $(XEN_ROOT)/tools/xenstore/include/*.h include/ && \
> ln -sf $(XEN_ROOT)/tools/xenstore/Makefile . )
> $(MAKE) DESTDIR= -C $(MINI_OS) links
> touch mk-headers-$(XEN_TARGET_ARCH)
> --
> 2.1.4
>
--
Samuel
bien sûr que ça convient mieux à tout le monde
enfin, dans la mesure où tout le monde c'est comme moi
-+- le consensus, c'est facile -+-
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] stubdom: fix link farm runes
2016-02-15 19:40 [PATCH] stubdom: fix link farm runes Wei Liu
2016-02-15 19:49 ` Wei Liu
2016-02-15 19:56 ` Samuel Thibault
@ 2016-02-16 9:10 ` Ian Campbell
2016-02-16 10:29 ` Wei Liu
2 siblings, 1 reply; 7+ messages in thread
From: Ian Campbell @ 2016-02-16 9:10 UTC (permalink / raw)
To: Wei Liu, Xen-devel; +Cc: Samuel Thibault, Ian Jackson, Stefano Stabellini
On Mon, 2016-02-15 at 19:40 +0000, Wei Liu wrote:
> Previously in the three problematic libraries all public headers were
> linked to source code directory. We should have created a include
> directory and link headers there.
What breakage arose from not having done so?
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> stubdom/Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/stubdom/Makefile b/stubdom/Makefile
> index 6f68e98..2044d76 100644
> --- a/stubdom/Makefile
> +++ b/stubdom/Makefile
> @@ -314,9 +314,9 @@ mk-headers-$(XEN_TARGET_ARCH):
> $(IOEMU_LINKFARM_TARGET)
> ln -sf $(wildcard $(XEN_ROOT)/tools/include/xen-foreign/*)
> include/xen-foreign/ && \
> $(MAKE) DESTDIR= -C include/xen-foreign/ && \
> ( [ -h include/xen/foreign ] || ln -sf ../xen-foreign
> include/xen/foreign )
> - mkdir -p libs-$(XEN_TARGET_ARCH)/toollog
> + mkdir -p libs-$(XEN_TARGET_ARCH)/toollog/include
> [ -h libs-$(XEN_TARGET_ARCH)/toollog/Makefile ] || ( cd libs
> -$(XEN_TARGET_ARCH)/toollog && \
> - ln -sf $(XEN_ROOT)/tools/libs/toollog/include/*.h . && \
> + ln -sf $(XEN_ROOT)/tools/libs/toollog/include/*.h include/
> && \
> ln -sf $(XEN_ROOT)/tools/libs/toollog/*.c . && \
> ln -sf $(XEN_ROOT)/tools/libs/toollog/Makefile . )
> mkdir -p libs-$(XEN_TARGET_ARCH)/evtchn/include
> @@ -343,17 +343,17 @@ mk-headers-$(XEN_TARGET_ARCH):
> $(IOEMU_LINKFARM_TARGET)
> ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/include/*.h
> include/ && \
> ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/*.c . && \
> ln -sf $(XEN_ROOT)/tools/libs/foreignmemory/Makefile . )
> - mkdir -p libxc-$(XEN_TARGET_ARCH)
> + mkdir -p libxc-$(XEN_TARGET_ARCH)/include
> [ -h libxc-$(XEN_TARGET_ARCH)/Makefile ] || ( cd libxc
> -$(XEN_TARGET_ARCH) && \
> ln -sf $(XEN_ROOT)/tools/libxc/*.h . && \
> - ln -sf $(XEN_ROOT)/tools/libxc/include/*.h . && \
> + ln -sf $(XEN_ROOT)/tools/libxc/include/*.h include/ && \
> ln -sf $(XEN_ROOT)/tools/libxc/*.c . && \
> ln -sf $(XEN_ROOT)/tools/libxc/Makefile . )
> - mkdir -p xenstore
> + mkdir -p xenstore/include
> [ -h xenstore/Makefile ] || ( cd xenstore && \
> ln -sf $(XEN_ROOT)/tools/xenstore/*.c . && \
> ln -sf $(XEN_ROOT)/tools/xenstore/*.h . && \
> - ln -sf $(XEN_ROOT)/tools/xenstore/include/*.h . && \
> + ln -sf $(XEN_ROOT)/tools/xenstore/include/*.h include/ &&
> \
> ln -sf $(XEN_ROOT)/tools/xenstore/Makefile . )
> $(MAKE) DESTDIR= -C $(MINI_OS) links
> touch mk-headers-$(XEN_TARGET_ARCH)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] stubdom: fix link farm runes
2016-02-16 9:10 ` Ian Campbell
@ 2016-02-16 10:29 ` Wei Liu
2016-02-16 12:14 ` Ian Campbell
0 siblings, 1 reply; 7+ messages in thread
From: Wei Liu @ 2016-02-16 10:29 UTC (permalink / raw)
To: Ian Campbell
Cc: Xen-devel, Wei Liu, Ian Jackson, Samuel Thibault,
Stefano Stabellini
On Tue, Feb 16, 2016 at 09:10:20AM +0000, Ian Campbell wrote:
> On Mon, 2016-02-15 at 19:40 +0000, Wei Liu wrote:
> > Previously in the three problematic libraries all public headers were
> > linked to source code directory. We should have created a include
> > directory and link headers there.
>
> What breakage arose from not having done so?
>
No visible breakage for these three packages. I noticed this deviation
when working on devicemodel library and thought they should follow the
same pattern as other libraries.
Wei.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] stubdom: fix link farm runes
2016-02-16 10:29 ` Wei Liu
@ 2016-02-16 12:14 ` Ian Campbell
2016-02-16 12:15 ` Wei Liu
0 siblings, 1 reply; 7+ messages in thread
From: Ian Campbell @ 2016-02-16 12:14 UTC (permalink / raw)
To: Wei Liu; +Cc: Xen-devel, Ian Jackson, Samuel Thibault, Stefano Stabellini
On Tue, 2016-02-16 at 10:29 +0000, Wei Liu wrote:
> On Tue, Feb 16, 2016 at 09:10:20AM +0000, Ian Campbell wrote:
> > On Mon, 2016-02-15 at 19:40 +0000, Wei Liu wrote:
> > > Previously in the three problematic libraries all public headers
> were
> > > linked to source code directory. We should have created a include
> > > directory and link headers there.
> >
> > What breakage arose from not having done so?
> >
>
> No visible breakage for these three packages. I noticed this deviation
> when working on devicemodel library and thought they should follow the
> same pattern as other libraries.
Thanks. This sort of thing is worth noting in the commit log.
Ian.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] stubdom: fix link farm runes
2016-02-16 12:14 ` Ian Campbell
@ 2016-02-16 12:15 ` Wei Liu
0 siblings, 0 replies; 7+ messages in thread
From: Wei Liu @ 2016-02-16 12:15 UTC (permalink / raw)
To: Ian Campbell
Cc: Xen-devel, Wei Liu, Ian Jackson, Samuel Thibault,
Stefano Stabellini
On Tue, Feb 16, 2016 at 12:14:33PM +0000, Ian Campbell wrote:
> On Tue, 2016-02-16 at 10:29 +0000, Wei Liu wrote:
> > On Tue, Feb 16, 2016 at 09:10:20AM +0000, Ian Campbell wrote:
> > > On Mon, 2016-02-15 at 19:40 +0000, Wei Liu wrote:
> > > > Previously in the three problematic libraries all public headers
> > were
> > > > linked to source code directory. We should have created a include
> > > > directory and link headers there.
> > >
> > > What breakage arose from not having done so?
> > >
> >
> > No visible breakage for these three packages. I noticed this deviation
> > when working on devicemodel library and thought they should follow the
> > same pattern as other libraries.
>
> Thanks. This sort of thing is worth noting in the commit log.
>
V2 coming shortly.
Wei.
> Ian.
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-02-16 12:16 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-15 19:40 [PATCH] stubdom: fix link farm runes Wei Liu
2016-02-15 19:49 ` Wei Liu
2016-02-15 19:56 ` Samuel Thibault
2016-02-16 9:10 ` Ian Campbell
2016-02-16 10:29 ` Wei Liu
2016-02-16 12:14 ` Ian Campbell
2016-02-16 12:15 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).