From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH] stubdom: fix link farm runes Date: Tue, 16 Feb 2016 12:15:35 +0000 Message-ID: <20160216121535.GJ10489@citrix.com> References: <1455565228-12729-1-git-send-email-wei.liu2@citrix.com> <1455613820.15441.18.camel@citrix.com> <20160216102935.GG10489@citrix.com> <1455624873.15441.58.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVeY2-0007f6-Eg for xen-devel@lists.xenproject.org; Tue, 16 Feb 2016 12:16:06 +0000 Content-Disposition: inline In-Reply-To: <1455624873.15441.58.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Xen-devel , Wei Liu , Ian Jackson , Samuel Thibault , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Tue, Feb 16, 2016 at 12:14:33PM +0000, Ian Campbell wrote: > On Tue, 2016-02-16 at 10:29 +0000, Wei Liu wrote: > > On Tue, Feb 16, 2016 at 09:10:20AM +0000, Ian Campbell wrote: > > > On Mon, 2016-02-15 at 19:40 +0000, Wei Liu wrote: > > > > Previously in the three problematic libraries all public headers > > were > > > > linked to source code directory. We should have created a include > > > > directory and link headers there. > > > > > > What breakage arose from not having done so? > > > > > > > No visible breakage for these three packages. I noticed this deviation > > when working on devicemodel library and thought they should follow the > > same pattern as other libraries. > > Thanks. This sort of thing is worth noting in the commit log. > V2 coming shortly. Wei. > Ian. >