From: Dario Faggioli <dario.faggioli@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Olaf Hering <olaf@aepfle.de>,
Tianyang Chen <tiche@seas.upenn.edu>,
Meng Xu <xumengpanda@gmail.com>,
George Dunlap <george.dunlap@citrix.com>
Subject: [PATCH v2 06/16] xen: sched: tracing: enable TSC tracing for all events
Date: Tue, 16 Feb 2016 19:11:53 +0100 [thread overview]
Message-ID: <20160216181153.27876.34317.stgit@Solace.station> (raw)
In-Reply-To: <20160216180550.27876.22680.stgit@Solace.station>
it is enabled for pretty much all of them already.
There were just a few that had it disabled.
When tracing a scheduler, timing information is
really important, so enable it everywhere scheduling
related.
Note that this was not really a problem if looking
at the traces with xenalyze, but it was if using
xentrace_format.
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
---
Cc: George Dunlap <george.dunlap@citrix.com>
Cc: Meng Xu <xumengpanda@gmail.com>
Cc: Tianyang Chen <tiche@seas.upenn.edu>
Cc: Olaf Hering <olaf@aepfle.de>
---
xen/common/sched_credit.c | 2 +-
xen/common/sched_credit2.c | 6 +++---
xen/common/sched_rt.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
index 5279b92..bd2f37f 100644
--- a/xen/common/sched_credit.c
+++ b/xen/common/sched_credit.c
@@ -476,7 +476,7 @@ static inline void __runq_tickle(struct csched_vcpu *new)
{
/* Avoid TRACE_*: saves checking !tb_init_done each step */
for_each_cpu(cpu, &mask)
- __trace_var(TRC_CSCHED_TICKLE, 0, sizeof(cpu), &cpu);
+ __trace_var(TRC_CSCHED_TICKLE, 1, sizeof(cpu), &cpu);
}
/* Send scheduler interrupts to designated CPUs */
diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
index cf40f68..2934e26 100644
--- a/xen/common/sched_credit2.c
+++ b/xen/common/sched_credit2.c
@@ -456,7 +456,7 @@ runq_insert(const struct scheduler *ops, unsigned int cpu, struct csched2_vcpu *
d.dom = svc->vcpu->domain->domain_id;
d.vcpu = svc->vcpu->vcpu_id;
d.pos = pos;
- trace_var(TRC_CSCHED2_RUNQ_POS, 0,
+ trace_var(TRC_CSCHED2_RUNQ_POS, 1,
sizeof(d),
(unsigned char *)&d);
}
@@ -564,7 +564,7 @@ tickle:
unsigned cpu:16, pad:16;
} d;
d.cpu = ipid; d.pad = 0;
- trace_var(TRC_CSCHED2_TICKLE, 0,
+ trace_var(TRC_CSCHED2_TICKLE, 1,
sizeof(d),
(unsigned char *)&d);
}
@@ -1721,7 +1721,7 @@ csched2_schedule(
*/
if ( tasklet_work_scheduled )
{
- trace_var(TRC_CSCHED2_SCHED_TASKLET, 0, 0, NULL);
+ trace_var(TRC_CSCHED2_SCHED_TASKLET, 1, 0, NULL);
snext = CSCHED2_VCPU(idle_vcpu[cpu]);
}
else
diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c
index 53de6d6..33ac9de 100644
--- a/xen/common/sched_rt.c
+++ b/xen/common/sched_rt.c
@@ -985,7 +985,7 @@ out:
} d;
d.cpu = cpu_to_tickle;
d.pad = 0;
- trace_var(TRC_RTDS_TICKLE, 0,
+ trace_var(TRC_RTDS_TICKLE, 1,
sizeof(d),
(unsigned char *)&d);
}
next prev parent reply other threads:[~2016-02-16 18:11 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 18:11 [PATCH v2 00/16] Scheduling related tracing improvements Dario Faggioli
2016-02-16 18:11 ` [PATCH v2 01/16] xen: sched: __runq_tickle takes a useless cpu parameter Dario Faggioli
2016-02-18 10:33 ` George Dunlap
2016-02-16 18:11 ` [PATCH v2 02/16] xen: sched: move up the trace record for vcpu_wake and vcpu_sleep Dario Faggioli
2016-02-18 10:34 ` George Dunlap
2016-02-16 18:11 ` [PATCH v2 03/16] xen: sched: improve domain creation tracing Dario Faggioli
2016-02-18 11:04 ` George Dunlap
2016-02-24 11:21 ` Dario Faggioli
2016-02-24 11:52 ` Jan Beulich
2016-02-24 13:20 ` Dario Faggioli
2016-02-16 18:11 ` [PATCH v2 04/16] xen: credit2: pack trace data better for xentrace_format Dario Faggioli
2016-02-18 11:10 ` George Dunlap
2016-02-18 13:42 ` Dario Faggioli
2016-02-16 18:11 ` [PATCH v2 05/16] xen: RTDS: " Dario Faggioli
2016-02-18 11:12 ` George Dunlap
2016-02-18 14:43 ` Meng Xu
2016-02-16 18:11 ` Dario Faggioli [this message]
2016-02-16 18:21 ` [PATCH v2 06/16] xen: sched: tracing: enable TSC tracing for all events Meng Xu
2016-02-17 9:52 ` Dario Faggioli
2016-02-17 15:26 ` Meng Xu
2016-02-18 11:43 ` George Dunlap
2016-02-18 16:52 ` Dario Faggioli
2016-02-22 11:02 ` George Dunlap
2016-02-16 18:12 ` [PATCH v2 07/16] xentrace: formats: update format of scheduling events Dario Faggioli
2016-02-18 12:28 ` George Dunlap
2016-02-16 18:12 ` [PATCH v2 08/16] xentrace: formats: add events from Credit scheduler Dario Faggioli
2016-02-16 18:12 ` [PATCH v2 09/16] xentrace: formats: add events from Credit2 scheduler Dario Faggioli
2016-02-16 18:12 ` [PATCH v2 10/16] xentrace: formats: add events from RTDS scheduler Dario Faggioli
2016-02-16 18:12 ` [PATCH v2 11/16] xentrace: formats: add domain create and destroy events Dario Faggioli
2016-02-16 18:12 ` [PATCH v2 12/16] xenalyze: handle scheduling events Dario Faggioli
2016-02-18 15:18 ` George Dunlap
2016-02-16 18:12 ` [PATCH v2 13/16] xenalyze: handle Credit1 scheduler events Dario Faggioli
2016-02-18 15:28 ` George Dunlap
2016-02-18 15:31 ` George Dunlap
2016-02-18 16:58 ` Dario Faggioli
2016-02-16 18:13 ` [PATCH v2 14/16] xenalyze: handle Credit2 " Dario Faggioli
2016-02-18 15:17 ` George Dunlap
2016-02-16 18:13 ` [PATCH v2 15/16] xenalyze: handle RTDS " Dario Faggioli
2016-02-18 15:28 ` George Dunlap
2016-02-18 17:02 ` Dario Faggioli
2016-02-18 17:06 ` George Dunlap
2016-02-18 17:10 ` Dario Faggioli
2016-02-16 18:13 ` [PATCH v2 16/16] xenalyze: handle DOM0 operaions events Dario Faggioli
2016-03-04 18:25 ` [PATCH v2 00/16] Scheduling related tracing improvements Dario Faggioli
2016-03-04 19:52 ` Konrad Rzeszutek Wilk
2016-03-07 10:50 ` Jan Beulich
2016-03-07 10:54 ` Wei Liu
2016-03-07 11:21 ` Jan Beulich
2016-03-07 11:27 ` Wei Liu
2016-03-07 14:21 ` Dario Faggioli
2016-03-07 15:36 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216181153.27876.34317.stgit@Solace.station \
--to=dario.faggioli@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=olaf@aepfle.de \
--cc=tiche@seas.upenn.edu \
--cc=xen-devel@lists.xenproject.org \
--cc=xumengpanda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).