From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH 0/4] xl: consolidate adhoc parsers Date: Tue, 16 Feb 2016 23:20:43 +0000 Message-ID: <20160216232043.GA31818@citrix.com> References: <1453463454-4114-1-git-send-email-wei.liu2@citrix.com> <56C39E21.7010600@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVovI-0006ic-Pq for xen-devel@lists.xenproject.org; Tue, 16 Feb 2016 23:20:48 +0000 Content-Disposition: inline In-Reply-To: <56C39E21.7010600@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jim Fehlig Cc: Xen-devel , Wei Liu List-Id: xen-devel@lists.xenproject.org On Tue, Feb 16, 2016 at 03:09:37PM -0700, Jim Fehlig wrote: > Wei Liu wrote: > > This patch series consolidates adhoc parsers in xl. > > Hi Wei, > > I never tested or reviewed this series after seeing Ian's comments. Did you have > time to work on a V2? Or did I miss a V2? :-) Let me know if I can help. > Sorry, this series fell through the crack -- it was only the work of one afternoon when I had some free cycles. Now I'm busy with other stuff and haven't had the time to pick it up again. One thing I'm not entirely happy with writing this in plain C is that there is subtle semantics difference from the ones generated by flex/bison even if they expose similar APIs. For example, the functions to parse disk spec won't allow you to set same attribute twice, while the work present in this function allows you to do that. It's cumbersome to implement the same functionality with open coding in C IMHO. To get to the point where I feel happy requires quite a bit of work, so I put "consolidating xl ad hoc parser" (a super set of this series) to this year's GSoC this morning. Basically I want to consolidate ad hoc parser, let them have similar semantics if possible, and then provide a test suite so that it won't be broken by mistake. That being said, perfection is the enemy of good. If you think this is important, I will try to find some time to refresh this series; but I don't have time for the test suite yet. You're welcome to take over this series if you have time. Wei. (Please forgive my errors in grammar etc, it's a bit late at night here...) > Regards, > Jim