Re: [PATCH] xenpaging: do not leak if --pagefile given twice

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, Feb 17, 2016 at 02:58:33PM +0000, Ian Campbell wrote:
> By freeing filename (which is either NULL or the previous iteration of
> this argument). This implements a semantic where the last --pagefile
> given on the command line takes precedence.
> 
> This is the same semantic as the other options have.
> 
> CID: 1198792
> 

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---
>  tools/xenpaging/xenpaging.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c
> index 0377507..6157d3a 100644
> --- a/tools/xenpaging/xenpaging.c
> +++ b/tools/xenpaging/xenpaging.c
> @@ -232,6 +232,7 @@ static int xenpaging_getopts(struct xenpaging *paging, int argc, char *argv[])
>              paging->vm_event.domain_id = atoi(optarg);
>              break;
>          case 'f':
> +            free(filename);
>              filename = strdup(optarg);
>              break;
>          case 'm':
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel