From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [RFC PATCH 4/7] common/pv-iommu: Add query, map and unmap ops Date: Wed, 17 Feb 2016 16:07:19 -0500 Message-ID: <20160217210719.GA26213@char.us.oracle.com> References: <1455099035-17649-1-git-send-email-malcolm.crossley@citrix.com> <1455099035-17649-5-git-send-email-malcolm.crossley@citrix.com> <20160217210509.GE25726@char.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160217210509.GE25726@char.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Malcolm Crossley Cc: andrew.cooper3@citrix.com, xen-devel@lists.xen.org, keir@xen.org, jbeulich@suse.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org > > ret_t do_iommu_op(XEN_GUEST_HANDLE_PARAM(void) arg, unsigned int count) > > Shouldn't this be changed to be pv_iommu_op_t? instead of void? > > > > { > > - return -ENOSYS; > > + ret_t ret = 0; > > + int i; > > unsigned int ? > > + struct pv_iommu_op op; > > + struct domain *d = current->domain; > > + > > + if ( !is_hardware_domain(d) ) > > + return -ENOSYS; > > -EPERM ? > > > + Also you are missing the XSM checks which should be here.