From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: libxl_device handling for nic and vtmp
Date: Thu, 18 Feb 2016 17:02:35 +0000
Message-ID: <20160218170235.GB24938@citrix.com>
References: <20160218151321.GA10541@aepfle.de>
	<20160218155219.GA7186@citrix.com> <20160218165438.GA1394@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <20160218165438.GA1394@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, Feb 18, 2016 at 05:54:38PM +0100, Olaf Hering wrote:
> On Thu, Feb 18, Wei Liu wrote:
> 
> > For example, user might not have specified mac address so the library
> > generates one for (s)he. You don't want mac address to regenerate after
> > save / restore or migration.  But you don't want to preserve all
> > autogenerated state, so you use the original copy as template and fill
> > it up as you see fit.
> 
> How does that fit into DEFINE_DEVICE_ADD? The functions do 1:1 copies,
> calling libxl__update_config_* looks unnecessary.
> 

Sorry I don't follow. What do you mean by 1:1 copy? Why does it make the
update unnecessary?

As said, we want some of the states but not all.

Wei.

> Olaf