From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Doug Goldstein <cardoe@cardoe.com>,
Xen-devel <xen-devel@lists.xen.org>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] hvmloader: Use xen/errno.h rather than the host systems errno.h
Date: Fri, 19 Feb 2016 10:40:36 +0000 [thread overview]
Message-ID: <20160219104036.GP3723@citrix.com> (raw)
In-Reply-To: <1455833409-19139-1-git-send-email-andrew.cooper3@citrix.com>
On Thu, Feb 18, 2016 at 10:10:09PM +0000, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Doug Goldstein <cardoe@cardoe.com>
> ---
> tools/firmware/hvmloader/xenbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/firmware/hvmloader/xenbus.c b/tools/firmware/hvmloader/xenbus.c
> index d0ed993..947d865 100644
> --- a/tools/firmware/hvmloader/xenbus.c
> +++ b/tools/firmware/hvmloader/xenbus.c
> @@ -27,7 +27,7 @@
>
> #include "util.h"
> #include "hypercall.h"
> -#include <errno.h>
> +#include <xen/errno.h>
This doesn't seem to compile for me. Xen's error numbers live in a
different name space.
Wei.
> #include <xen/sched.h>
> #include <xen/event_channel.h>
> #include <xen/hvm/params.h>
> --
> 2.1.4
>
next prev parent reply other threads:[~2016-02-19 10:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 22:10 [PATCH] hvmloader: Use xen/errno.h rather than the host systems errno.h Andrew Cooper
2016-02-19 2:21 ` Doug Goldstein
2016-02-19 2:32 ` Konrad Rzeszutek Wilk
2016-02-19 10:40 ` Wei Liu [this message]
2016-02-19 10:50 ` Andrew Cooper
2016-02-19 10:53 ` Wei Liu
2016-02-19 11:00 ` Ian Campbell
2016-02-19 11:09 ` Andrew Cooper
2016-02-19 11:16 ` Ian Campbell
2016-02-19 10:55 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219104036.GP3723@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).