From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Doug Goldstein <cardoe@cardoe.com>,
Xen-devel <xen-devel@lists.xen.org>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] hvmloader: Use xen/errno.h rather than the host systems errno.h
Date: Fri, 19 Feb 2016 10:53:30 +0000 [thread overview]
Message-ID: <20160219105330.GR3723@citrix.com> (raw)
In-Reply-To: <56C6F375.4040001@citrix.com>
On Fri, Feb 19, 2016 at 10:50:29AM +0000, Andrew Cooper wrote:
> On 19/02/16 10:40, Wei Liu wrote:
> > On Thu, Feb 18, 2016 at 10:10:09PM +0000, Andrew Cooper wrote:
> >> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >> ---
> >> CC: Jan Beulich <JBeulich@suse.com>
> >> CC: Ian Campbell <Ian.Campbell@citrix.com>
> >> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> >> CC: Wei Liu <wei.liu2@citrix.com>
> >> CC: Doug Goldstein <cardoe@cardoe.com>
> >> ---
> >> tools/firmware/hvmloader/xenbus.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/firmware/hvmloader/xenbus.c b/tools/firmware/hvmloader/xenbus.c
> >> index d0ed993..947d865 100644
> >> --- a/tools/firmware/hvmloader/xenbus.c
> >> +++ b/tools/firmware/hvmloader/xenbus.c
> >> @@ -27,7 +27,7 @@
> >>
> >> #include "util.h"
> >> #include "hypercall.h"
> >> -#include <errno.h>
> >> +#include <xen/errno.h>
> > This doesn't seem to compile for me. Xen's error numbers live in a
> > different name space.
>
> It compiled fine for me. HVMLoader should use __XEN_TOOLS__.
>
> Let me double check after a fully clean build.
>
On staging:
make[1]: Entering directory '/local/scratch/xen.git/tools/firmware/hvmloader'
gcc -O1 -fno-omit-frame-pointer -m32 -march=i686 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -O0 -g3 -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MF .xenbus.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -mno-tls-direct-seg-refs -Werror -fno-stack-protector -fno-exceptions -fno-builtin -msoft-float -I/local/scratch/xen.git/tools/firmware/hvmloader/../../../tools/include -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -DENABLE_ROMBIOS -DENABLE_SEABIOS -c -o xenbus.o xenbus.c
xenbus.c: In function ‘xenbus_recv’:
xenbus.c:235:35: error: ‘xsd_errors’ undeclared (first use in this function)
for ( i = 0; i < ((sizeof xsd_errors) / (sizeof xsd_errors[0])); i++ )
^
xenbus.c:235:35: note: each undeclared identifier is reported only once for each function it appears in
xenbus.c:239:16: error: ‘EIO’ undeclared (first use in this function)
return EIO;
^
xenbus.c: In function ‘xenstore_write’:
xenbus.c:295:15: error: ‘EIO’ undeclared (first use in this function)
ret = EIO;
^
/local/scratch/xen.git/tools/firmware/hvmloader/../../../tools/Rules.mk:191: recipe for target 'xenbus.o' failed
make[1]: *** [xenbus.o] Error 1
make[1]: Leaving directory '/local/scratch/xen.git/tools/firmware/hvmloader'
Makefile:93: recipe for target 'all' failed
make: *** [all] Error 2
I actually had a similar patch stashed in my queue but that was the
reason I never sent it out...
Wei.
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-19 10:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 22:10 [PATCH] hvmloader: Use xen/errno.h rather than the host systems errno.h Andrew Cooper
2016-02-19 2:21 ` Doug Goldstein
2016-02-19 2:32 ` Konrad Rzeszutek Wilk
2016-02-19 10:40 ` Wei Liu
2016-02-19 10:50 ` Andrew Cooper
2016-02-19 10:53 ` Wei Liu [this message]
2016-02-19 11:00 ` Ian Campbell
2016-02-19 11:09 ` Andrew Cooper
2016-02-19 11:16 ` Ian Campbell
2016-02-19 10:55 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219105330.GR3723@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).