From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 1/4] tools/configure: only require bcc/ld86/as86 when needed
Date: Fri, 19 Feb 2016 09:00:37 -0500 [thread overview]
Message-ID: <20160219140036.GB31079@localhost.localdomain> (raw)
In-Reply-To: <1455850625-9624-1-git-send-email-cardoe@cardoe.com>
On Thu, Feb 18, 2016 at 08:57:02PM -0600, Doug Goldstein wrote:
> bcc/ld86/as86 are only necessary when we build rombios and not always so
> failing the build when they aren't available should not happen if the
> user isn't building rombios.
That is quite the long sentence. Perhaps trim it down to:
"are necessary when we build ROMBIOS. However if we do not build it
(not building qemu-trad) - the build requirements are overly strict
and can lead to failures." ?
Otherwise
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
next prev parent reply other threads:[~2016-02-19 14:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 2:57 [PATCH v2 1/4] tools/configure: only require bcc/ld86/as86 when needed Doug Goldstein
2016-02-19 2:57 ` [PATCH v2 2/4] m4/python: fix typo in LDFLAGS variable name Doug Goldstein
2016-02-19 14:02 ` Konrad Rzeszutek Wilk
2016-02-22 16:10 ` Ian Jackson
2016-02-19 2:57 ` [PATCH v2 3/4] m4/python: fix checks for Python library support Doug Goldstein
2016-02-22 16:22 ` Ian Jackson
2016-02-22 19:14 ` Doug Goldstein
2016-02-29 18:00 ` Doug Goldstein
2016-03-01 18:06 ` Ian Jackson
2016-02-23 2:25 ` Doug Goldstein
2016-02-19 2:57 ` [PATCH v2 4/4] configure: rerun autoconf Doug Goldstein
2016-02-22 16:20 ` Ian Jackson
2016-02-19 14:00 ` Konrad Rzeszutek Wilk [this message]
2016-02-19 14:27 ` [PATCH v2 1/4] tools/configure: only require bcc/ld86/as86 when needed Doug Goldstein
2016-02-22 14:37 ` Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219140036.GB31079@localhost.localdomain \
--to=konrad.wilk@oracle.com \
--cc=cardoe@cardoe.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).