From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: git workflow and http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches Date: Fri, 19 Feb 2016 11:59:17 -0500 Message-ID: <20160219165917.GA11078@char.us.oracle.com> References: <20160215160057.GA4308@char.us.oracle.com> <56C1F859.7040007@citrix.com> <56C211EF02000078000D2514@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aWoOu-00027h-MS for xen-devel@lists.xenproject.org; Fri, 19 Feb 2016 16:59:28 +0000 Content-Disposition: inline In-Reply-To: <56C211EF02000078000D2514@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Roger Pau =?iso-8859-1?Q?Monn=E9?= List-Id: xen-devel@lists.xenproject.org On Mon, Feb 15, 2016 at 09:59:11AM -0700, Jan Beulich wrote: > >>> On 15.02.16 at 17:10, wrote: > > El 15/2/16 a les 17:00, Konrad Rzeszutek Wilk ha escrit: > >> Hey, > >> > >> I wanted to ask what folks would think of expanding the Wiki to include > > (making it a diff > >> for simpler) this change. With my giant 30 set of patches that not only CC-ed > >> xen-devel twice but had some patches CC some maintainers but not others - I > > figured > >> it may be good to describe this in the Wiki: > >> > >> --- orig 2016-02-15 10:45:27.719204371 -0500 > >> +++ new 2016-02-15 10:58:33.113755665 -0500 > >> @@ -140,7 +140,35 @@ > >> * The maintainers are listed in the MAINTAINERS file at the top of the Xen > > source tree. If no maintainer is listed then there is no need for a CC (if > > you are modifying code with no maintainer then you might like to consider > > becoming the maintainer for that piece of code!). > >> ** You can pipe your patch to the ./scripts/get_maintainer.pl tool > > and it will list the relevant maintainers. > >> * In addition to CCing the maintainer you should always send patches to > > (via TO) the xen-devel@lists.xenproject.org mailing list as well. > >> -* To add a CC when sending the mail you can use the ''--cc'' option to the ''git send-email'' command, or you can do it manually in your MUA. > >> +* To add a CC when sending the mail you can: > >> + * use the ''--cc'' option to the ''git send-email'' command - however if your > >> + patchset is to multiple maintainers - you may end up sending all of the > >> + patches to all maintainers - where some of them have no interest in > >> + viewing them (as they are not under their responsibility). > >> + * edit each patch to have the proper maintainer on the CC list by adding: > >> +
> >> +CC: joe@doe.com 
> > 
> > I'm not a maintainer/committer myself, but since we are spelling this
> > out, I think maintainers/committers prefer that the "Cc:" tags are
> > placed after a "---".
> 
> While I'm one of those who indeed does, I recall there having been
> different views (derived from there being different view on whether
> it is a good idea to retain these Cc-s in what gets committed).
> 


How about:


--- orig	2016-02-15 10:45:27.719204371 -0500
+++ new	2016-02-19 11:57:34.827213537 -0500
@@ -140,7 +140,42 @@
 * The maintainers are listed in the MAINTAINERS file at the top of the Xen source tree. If no maintainer is listed then there is no need for a CC (if you are modifying code with no maintainer then you might like to consider becoming the maintainer for that piece of code!).
 ** You can pipe your patch to the ./scripts/get_maintainer.pl tool and it will list the relevant maintainers.
 * In addition to CCing the maintainer you should always send patches to (via TO) the xen-devel@lists.xenproject.org mailing list as well.
-* To add a CC when sending the mail you can use the ''--cc'' option to the ''git send-email'' command, or you can do it manually in your MUA.
+* To add a CC when sending the mail you can:
+  * use the ''--cc'' option to the ''git send-email'' command - however if your
+    patchset is to multiple maintainers - you may end up sending all of the
+    patches to all maintainers  - where some of them have no interest in
+    viewing them (as they are not under their responsibility)
+  * edit each patch to have the proper maintainer on the CC list by adding:
+
+---
+CC: joe@example.com
+---
+

+   in the patch. The ''---'' means that when the patch is applied the text
+in between them is discarded.
+  * or alternatively use --cc-cmd in your .gitconfig or git-send-email:
+
+[sendemail]
+    cc-cmd = scripts/get_maintainer.pl --no-l
+

+or:
+
+git send-email --cc-cmd="scripts/get_maintainer.pl 
+

+which will automatically add the proper maintainer on the CC line.
+The ''no-l'' is to not add the mailing list to the CC (as you would
+be adding that via the TO - see above)
+  * or you can do it manually in your MUA.
+
+In short, it could look like this:
+
+$pwd
+/home/joe/xen
+git send-email --cc-cmd="scripts/get_maintainer.pl --no-l --to xen-devel@lists.xenproject.org --to jo@example.com --compose --subject "[PATCH v1] Fixes to frobnicator." *.patch
+

+
+Which will send all patches to yourself on the TO, to xen-devel mailiing list (on the TO:)
+and the patches will have their CC: list generated based on scripts/get_maintainer.pl.
 
 === Providing a git branch ===