From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH v8 05/13] tools/libxc: support to resume uncooperative HVM guests Date: Fri, 19 Feb 2016 17:21:01 +0000 Message-ID: <20160219172101.GX3723@citrix.com> References: <1455763403-18641-1-git-send-email-wency@cn.fujitsu.com> <1455763403-18641-6-git-send-email-wency@cn.fujitsu.com> <20160218121336.GG3723@citrix.com> <20160219141537.GD31079@localhost.localdomain> <20160219144350.GT3723@citrix.com> <1455893531.6225.106.camel@citrix.com> <20160219151627.GU3723@citrix.com> <20160219162007.GD31685@char.us.oracle.com> <20160219164220.GW3723@citrix.com> <20160219171631.GE11161@char.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160219171631.GE11161@char.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Lars Kurth , Changlong Xie , Wei Liu , Ian Campbell , Wen Congyang , Andrew Cooper , Jiang Yunhong , Ian Jackson , xen devel , Dong Eddie , Gui Jianfeng , Shriram Rajagopalan , Yang Hongyang List-Id: xen-devel@lists.xenproject.org On Fri, Feb 19, 2016 at 12:16:31PM -0500, Konrad Rzeszutek Wilk wrote: > > > .. forbid what? PVHVM resuming with fast=0? Why? Because the guest may > > > fall on its face? > > > > Yes, forbid resuming PVHVM with fast=0 if we have no clear definition of > > how it works. It's not because guest would fall, it's because we can't > > tell which side (the guest or the toolstack) is buggy when the guest > > falls. > > > > But it looks like we (you ;-) ) have clear idea of how it works, we > > (you) just need to write it down. > > > Where? The header file where SHUTDOWN_suspend is introduced? > > Or the libxc ones? I have no opinion whether Xen public header should contain such text, but I do wish to have better document for xc_domain_resume. Basically it is just turning what you wrote in this thread to comment for xc_domain_resume. Wei.