From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v3 01/23] xen/xsplice: Hypervisor
 implementation of XEN_XSPLICE_op (v10)
Date: Fri, 19 Feb 2016 14:36:01 -0500
Message-ID: <20160219193601.GB11420@localhost.localdomain>
References: <1455300361-13092-1-git-send-email-konrad.wilk@oracle.com>
	<1455300361-13092-2-git-send-email-konrad.wilk@oracle.com>
	<56BE3C7D.3030303@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <konrad.wilk@oracle.com>) id 1aWqqe-0002fB-V0
	for xen-devel@lists.xenproject.org; Fri, 19 Feb 2016 19:36:17 +0000
Content-Disposition: inline
In-Reply-To: <56BE3C7D.3030303@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, jinsong.liu@alibaba-inc.com, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, mpohlack@amazon.de, ross.lagerwall@citrix.com, xen-devel@lists.xenproject.org, Daniel De Graaf <dgdegra@tycho.nsa.gov>, sasha.levin@citrix.com
List-Id: xen-devel@lists.xenproject.org

> >  long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
> >  {
> > @@ -460,6 +461,12 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
> >          ret = tmem_control(&op->u.tmem_op);
> >          break;
> >  
> > +    case XEN_SYSCTL_xsplice_op:
> > +        ret = xsplice_control(&op->u.xsplice);
> 
> Could we name this do_xsplice_op() to match prevailing subop style.

There are two instances of that: do_get_pm_info, do_pm_op.

Then variations of 'do' are: cpupool_do_sysctl, arch_do_physinfo, and
arch_do_sysctl.

And then ones enjoying 'op' in it:
sysctl_coverage_op

And then 'control' ones:
spinlock_profile_control, tmem_control, perfc_control, tb_control.

So we have 2 vs 3 vs 1 vs 4.

I would say that the name 'xsplice_control' is the prevailing style?

Unless you want me to take a union of them, perhaps:

 do_xsplice_control_op ?

<chuckles>

I will change it to what you prefer - do_xsplice_op.
> 
> > +        if ( ret != -ENOSYS )
> > +            copyback = 1;
> > +        break;
> > +
> 
> Not related to this patch.  I (and by this, I mean someone with time ;p)
> should do some cleanup and pass copyback by pointer to subops.  This
> allows for finer grain control of whether a copyback is needed.

Yes indeed. But then how often do you do sysctl hypercalls?