From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v3 06/23] xsplice: Implement payload loading
	(v4)
Date: Fri, 19 Feb 2016 17:03:57 -0500
Message-ID: <20160219220356.GF11420@localhost.localdomain>
References: <1455300361-13092-1-git-send-email-konrad.wilk@oracle.com>
	<1455300361-13092-7-git-send-email-konrad.wilk@oracle.com>
	<56BE4502.1090706@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <konrad.wilk@oracle.com>) id 1aWt9t-00012U-P8
	for xen-devel@lists.xenproject.org; Fri, 19 Feb 2016 22:04:17 +0000
Content-Disposition: inline
In-Reply-To: <56BE4502.1090706@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, jinsong.liu@alibaba-inc.com, xen-devel@lists.xen.org, mpohlack@amazon.de, ross.lagerwall@citrix.com, Stefano Stabellini <stefano.stabellini@citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org, sasha.levin@citrix.com
List-Id: xen-devel@lists.xenproject.org

> > +         hdr->e_ident[EI_CLASS] != ELFCLASS64 ||
> > +         hdr->e_ident[EI_DATA] != ELFDATA2LSB ||
> > +         hdr->e_ident[EI_OSABI] != ELFOSABI_SYSV ||
> > +         hdr->e_machine != EM_X86_64 ||
> > +         hdr->e_type != ET_REL ||
> > +         hdr->e_phnum != 0 )
> > +    {
> > +        printk(XENLOG_ERR "%s: Invalid ELF file.\n", elf->name);
> 
> Where possible, please avoid punction in error messages.  Its just
> wasted characters on the uart.
> 
> I would also suggest the error message be "xpatch '%s': Invalid ELF
> file\n" to give the observer some clue that we are referring to payload
> attached to a specific xsplice patch.

Isn't elf->name doing that already?
> 
> > +        return -EOPNOTSUPP;
> > +    }
> > +
> > +    return 0;
> > +}
> > +
> > +int xsplice_perform_rel(struct xsplice_elf *elf,
> > +                        struct xsplice_elf_sec *base,
> > +                        struct xsplice_elf_sec *rela)
> > +{
> > +    printk(XENLOG_ERR "%s: SHR_REL relocation unsupported\n", elf->name);
> 
> Simiarly here.  All the error messages should have some common
> indication that we are in the xsplice subsystem.

I changed that one to dprintk so it will have it. Let me add the xSplice
be part of the naming convention in all the printk's that can come about
in the field.