From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] version: Document guest_handle Date: Tue, 23 Feb 2016 14:04:01 -0500 Message-ID: <20160223190401.GA15838@char.us.oracle.com> References: <1455877209.6225.75.camel@citrix.com> <1455892362-1560-1-git-send-email-konrad.wilk@oracle.com> <56CB0E0502000078000D4B49@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="EVF5PPMfhYS0aIcm" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYIFz-0004wo-Vf for xen-devel@lists.xenproject.org; Tue, 23 Feb 2016 19:04:24 +0000 Content-Disposition: inline In-Reply-To: <56CB0E0502000078000D4B49@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , Ian Campbell , rcojocaru@bitdefender.com, Tim Deegan , Ian Jackson , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org --EVF5PPMfhYS0aIcm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 22, 2016 at 05:32:53AM -0700, Jan Beulich wrote: > >>> On 19.02.16 at 15:32, wrote: > > --- a/xen/include/public/version.h > > +++ b/xen/include/public/version.h > > @@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t; > > #define XENVER_pagesize 7 > > > > /* arg == xen_domain_handle_t. */ > > +/* > > + * The toolstack fills it out for the guest consumption. Usually it is > > + * the UUID of the guest but can be anything. > > + */ > > #define XENVER_guest_handle 8 > > Generally fine, but I'm not overly happy with the wording. I'd > prefer if it was made slightly less vague this is meant to be the > UUID. Maybe "The toolstack fills it out for guest consumption. It > is intended to hold the UUID of the guest"? > > Jan > Attached as well: >>From 7da6d169835acb4aa93bfa48b1ae6b8e198f8e5f Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Fri, 19 Feb 2016 09:26:02 -0500 Subject: [PATCH] version: Document guest_handle And what it is usually used for. Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Razvan Cojocaru --- v2: Reword per Jan's suggestion. --- xen/include/public/version.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/include/public/version.h b/xen/include/public/version.h index adca602..5e6a7ea 100644 --- a/xen/include/public/version.h +++ b/xen/include/public/version.h @@ -78,7 +78,11 @@ typedef struct xen_feature_info xen_feature_info_t; /* arg == NULL; returns host memory page size. */ #define XENVER_pagesize 7 -/* arg == xen_domain_handle_t. */ +/* arg == xen_domain_handle_t. + * + * The toolstack fills it out for guest consumption. It is intended to hold + * the UUID of the guest. + */ #define XENVER_guest_handle 8 #define XENVER_commandline 9 -- 2.1.0 --EVF5PPMfhYS0aIcm Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-version-Document-guest_handle.patch" >>From 7da6d169835acb4aa93bfa48b1ae6b8e198f8e5f Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Fri, 19 Feb 2016 09:26:02 -0500 Subject: [PATCH] version: Document guest_handle And what it is usually used for. Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Razvan Cojocaru --- v2: Reword per Jan's suggestion. --- xen/include/public/version.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/include/public/version.h b/xen/include/public/version.h index adca602..5e6a7ea 100644 --- a/xen/include/public/version.h +++ b/xen/include/public/version.h @@ -78,7 +78,11 @@ typedef struct xen_feature_info xen_feature_info_t; /* arg == NULL; returns host memory page size. */ #define XENVER_pagesize 7 -/* arg == xen_domain_handle_t. */ +/* arg == xen_domain_handle_t. + * + * The toolstack fills it out for guest consumption. It is intended to hold + * the UUID of the guest. + */ #define XENVER_guest_handle 8 #define XENVER_commandline 9 -- 2.1.0 --EVF5PPMfhYS0aIcm Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --EVF5PPMfhYS0aIcm--