From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ross Lagerwall <ross.lagerwall@citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 07/23] xsplice: Implement support for applying/reverting/replacing patches. (v5)
Date: Tue, 23 Feb 2016 15:47:28 -0500 [thread overview]
Message-ID: <20160223204728.GD15838@char.us.oracle.com> (raw)
In-Reply-To: <56CB3FF9.50305@citrix.com>
>
> Also above, you've got:
> list_for_each_entry_safe_reverse ( data, tmp, &applied_list, list )
>
> but it needs to be:
> list_for_each_entry_safe_reverse ( data, tmp, &applied_list, applied_list )
Totally mised it.
>
> I'm not sure why this was changed from how I had it...
I had issues applying the patch so I modified it by hand - which
was of course the wrong thing to do. Let me also document
that we MUST use the 'applied_list' list.
>
> rc is also used uninitialized in the replace path.
>
> --
> Ross Lagerwall
next prev parent reply other threads:[~2016-02-23 20:47 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 18:05 [PATCH v3] xSplice v1 implementation and design Konrad Rzeszutek Wilk
2016-02-12 18:05 ` [PATCH v3 01/23] xen/xsplice: Hypervisor implementation of XEN_XSPLICE_op (v10) Konrad Rzeszutek Wilk
2016-02-12 20:11 ` Andrew Cooper
2016-02-12 20:40 ` Konrad Rzeszutek Wilk
2016-02-12 20:53 ` Andrew Cooper
2016-02-15 8:16 ` Jan Beulich
2016-02-19 19:36 ` Konrad Rzeszutek Wilk
2016-02-19 19:43 ` Andrew Cooper
2016-02-12 18:05 ` [PATCH v3 02/23] libxc: Implementation of XEN_XSPLICE_op in libxc (v5) Konrad Rzeszutek Wilk
2016-02-15 12:35 ` Wei Liu
2016-02-19 20:04 ` Konrad Rzeszutek Wilk
2016-02-12 18:05 ` [PATCH v3 03/23] xen-xsplice: Tool to manipulate xsplice payloads (v4) Konrad Rzeszutek Wilk
2016-02-15 12:59 ` Wei Liu
2016-02-19 20:46 ` Konrad Rzeszutek Wilk
2016-02-12 18:05 ` [PATCH v3 04/23] elf: Add relocation types to elfstructs.h Konrad Rzeszutek Wilk
2016-02-12 20:13 ` Andrew Cooper
2016-02-15 8:34 ` Jan Beulich
2016-02-19 21:05 ` Konrad Rzeszutek Wilk
2016-02-22 10:17 ` Jan Beulich
2016-02-22 15:19 ` Ross Lagerwall
2016-02-12 18:05 ` [PATCH v3 05/23] xsplice: Add helper elf routines (v4) Konrad Rzeszutek Wilk
2016-02-12 20:24 ` Andrew Cooper
2016-02-12 20:47 ` Konrad Rzeszutek Wilk
2016-02-12 20:52 ` Andrew Cooper
2016-02-12 18:05 ` [PATCH v3 06/23] xsplice: Implement payload loading (v4) Konrad Rzeszutek Wilk
2016-02-12 20:48 ` Andrew Cooper
2016-02-19 22:03 ` Konrad Rzeszutek Wilk
2016-02-12 18:05 ` [PATCH v3 07/23] xsplice: Implement support for applying/reverting/replacing patches. (v5) Konrad Rzeszutek Wilk
2016-02-16 19:11 ` Andrew Cooper
2016-02-17 8:58 ` Ross Lagerwall
2016-02-17 10:50 ` Jan Beulich
2016-02-19 9:30 ` Ross Lagerwall
2016-02-23 20:41 ` Konrad Rzeszutek Wilk
2016-02-23 20:53 ` Konrad Rzeszutek Wilk
2016-02-23 20:57 ` Konrad Rzeszutek Wilk
2016-02-23 21:10 ` Andrew Cooper
2016-02-24 9:31 ` Jan Beulich
2016-02-22 15:00 ` Ross Lagerwall
2016-02-22 17:06 ` Ross Lagerwall
2016-02-23 20:47 ` Konrad Rzeszutek Wilk [this message]
2016-02-23 20:43 ` Konrad Rzeszutek Wilk
2016-02-12 18:05 ` [PATCH v3 08/23] x86/xen_hello_world.xsplice: Test payload for patching 'xen_extra_version'. (v2) Konrad Rzeszutek Wilk
2016-02-16 11:31 ` Ross Lagerwall
2016-02-12 18:05 ` [PATCH v3 09/23] xsplice: Add support for bug frames. (v4) Konrad Rzeszutek Wilk
2016-02-16 19:35 ` Andrew Cooper
2016-02-24 16:22 ` Konrad Rzeszutek Wilk
2016-02-24 16:30 ` Andrew Cooper
2016-02-24 16:26 ` Konrad Rzeszutek Wilk
2016-02-12 18:05 ` [PATCH v3 10/23] xsplice: Add support for exception tables. (v2) Konrad Rzeszutek Wilk
2016-02-12 18:05 ` [PATCH v3 11/23] xsplice: Add support for alternatives Konrad Rzeszutek Wilk
2016-02-16 19:41 ` Andrew Cooper
2016-02-12 18:05 ` [PATCH v3 12/23] xsm/xen_version: Add XSM for the xen_version hypercall (v8) Konrad Rzeszutek Wilk
2016-02-12 21:52 ` Daniel De Graaf
2016-02-12 18:05 ` [PATCH v3 13/23] XENVER_build_id: Provide ld-embedded build-ids (v10) Konrad Rzeszutek Wilk
2016-02-12 21:52 ` Daniel De Graaf
2016-02-16 20:09 ` Andrew Cooper
2016-02-16 20:22 ` Konrad Rzeszutek Wilk
2016-02-16 20:26 ` Andrew Cooper
2016-02-16 20:40 ` Konrad Rzeszutek Wilk
2016-02-24 18:52 ` Konrad Rzeszutek Wilk
2016-02-24 19:13 ` Andrew Cooper
2016-02-24 20:54 ` Konrad Rzeszutek Wilk
2016-02-12 18:05 ` [PATCH v3 14/23] libxl: info: Display build_id of the hypervisor Konrad Rzeszutek Wilk
2016-02-15 12:45 ` Wei Liu
2016-02-12 18:05 ` [PATCH v3 15/23] xsplice: Print build_id in keyhandler Konrad Rzeszutek Wilk
2016-02-16 20:13 ` Andrew Cooper
2016-02-12 18:05 ` [PATCH v3 16/23] xsplice: basic build-id dependency checking Konrad Rzeszutek Wilk
2016-02-12 18:05 ` [PATCH v3 17/23] xsplice: Print dependency and payloads build_id in the keyhandler Konrad Rzeszutek Wilk
2016-02-16 20:20 ` Andrew Cooper
2016-02-17 11:10 ` Jan Beulich
2016-02-24 21:54 ` Konrad Rzeszutek Wilk
2016-02-25 8:47 ` Jan Beulich
2016-02-12 18:05 ` [PATCH v3 18/23] xsplice: Prevent duplicate payloads to be loaded Konrad Rzeszutek Wilk
2016-02-12 18:05 ` [PATCH v3 19/23] xsplice, symbols: Implement symbol name resolution on address. (v2) Konrad Rzeszutek Wilk
2016-02-22 14:57 ` Ross Lagerwall
2016-02-12 18:05 ` [PATCH v3 20/23] x86, xsplice: Print payload's symbol name and module in backtraces Konrad Rzeszutek Wilk
2016-02-12 18:05 ` [PATCH v3 21/23] xsplice: Add support for shadow variables Konrad Rzeszutek Wilk
2016-03-07 7:40 ` Martin Pohlack
2016-03-15 18:02 ` Konrad Rzeszutek Wilk
2016-03-07 18:52 ` Martin Pohlack
2016-02-12 18:06 ` [PATCH v3 22/23] xsplice: Add hooks functions and other macros Konrad Rzeszutek Wilk
2016-02-12 18:06 ` [PATCH v3 23/23] xsplice, hello_world: Use the XSPLICE_[UN|]LOAD_HOOK hooks for two functions Konrad Rzeszutek Wilk
2016-02-12 21:57 ` [PATCH v3] xSplice v1 implementation and design Konrad Rzeszutek Wilk
2016-02-12 21:57 ` [PATCH v3 MISSING/23] xsplice: Design document (v7) Konrad Rzeszutek Wilk
2016-02-18 16:20 ` Jan Beulich
2016-02-19 18:36 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223204728.GD15838@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=ross.lagerwall@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).