From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v3 07/23] xsplice: Implement support for applying/reverting/replacing patches. (v5) Date: Tue, 23 Feb 2016 15:47:28 -0500 Message-ID: <20160223204728.GD15838@char.us.oracle.com> References: <1455300361-13092-1-git-send-email-konrad.wilk@oracle.com> <1455300361-13092-8-git-send-email-konrad.wilk@oracle.com> <56CB228F.2090101@citrix.com> <56CB3FF9.50305@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYJrr-00013g-IR for xen-devel@lists.xenproject.org; Tue, 23 Feb 2016 20:47:35 +0000 Content-Disposition: inline In-Reply-To: <56CB3FF9.50305@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ross Lagerwall Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org > > Also above, you've got: > list_for_each_entry_safe_reverse ( data, tmp, &applied_list, list ) > > but it needs to be: > list_for_each_entry_safe_reverse ( data, tmp, &applied_list, applied_list ) Totally mised it. > > I'm not sure why this was changed from how I had it... I had issues applying the patch so I modified it by hand - which was of course the wrong thing to do. Let me also document that we MUST use the 'applied_list' list. > > rc is also used uninitialized in the replace path. > > -- > Ross Lagerwall