From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH] Config.mk: Update SEABIOS_UPSTREAM_TAG to rel-1.9.1 Date: Wed, 24 Feb 2016 15:50:07 +0000 Message-ID: <20160224155007.GD5694@citrix.com> References: <1455547082-6890-1-git-send-email-cardoe@cardoe.com> <20160215161354.GA11740@citrix.com> <1455630206.814.82.camel@citrix.com> <20160216135228.GP10489@citrix.com> <56CDBF77.2070103@cardoe.com> <20160224144142.GA5694@citrix.com> <56CDD6D102000078000D5C47@prv-mh.provo.novell.com> <20160224151818.GB5694@citrix.com> <56CDDDFC02000078000D5CBB@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <56CDDDFC02000078000D5CBB@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Tim Deegan , Keir Fraser , IanCampbell , Doug Goldstein , Ian Jackson , xen-devel@lists.xen.org, Wei Liu List-Id: xen-devel@lists.xenproject.org On Wed, Feb 24, 2016 at 08:44:44AM -0700, Jan Beulich wrote: > >>> On 24.02.16 at 16:18, wrote: > > On Wed, Feb 24, 2016 at 08:14:09AM -0700, Jan Beulich wrote: > >> >>> On 24.02.16 at 15:41, wrote: > >> > On Wed, Feb 24, 2016 at 08:34:31AM -0600, Doug Goldstein wrote: > >> >> On 2/16/16 7:52 AM, Wei Liu wrote: > >> >> > On Tue, Feb 16, 2016 at 01:43:26PM +0000, Ian Campbell wrote: > >> >> >> On Mon, 2016-02-15 at 16:13 +0000, Wei Liu wrote: > >> >> >>> On Mon, Feb 15, 2016 at 08:38:02AM -0600, Doug Goldstein wrote: > >> >> >>>> Switch from tracking a commit post 1.9.0 to the 1.9.1 release. > >> >> >>>> > >> >> >>> > >> >> >>> Thanks for this patch. > >> >> >>> > >> >> >>> We can't apply this patch just yet. We need to wait a bit until the > >> >> >>> change to upstream trickles down to our own tree [0] -- OSSTest will > >> >> >>> work on that shortly. See [1] for an example output. > >> >> >> > >> >> >> Our osstest branch only tests seabios.git#master whereas this is tracking > >> >> >> the 1.9.x stable branch. > >> >> >> > >> >> >> I don't think we really want/need the overhead of testing multiple > > branches > >> >> >> of SeaBIOS, so IMHO it is sufficient to observe that all of the commits on > >> >> >> the stable branch have passed our master branch commit gate (even if that > >> >> >> means they did so in the context of other un-backported patches). I haven't > >> >> >> checked but given the timings and http://logs.test-lab.xenproject.org/osste > > > >> >> >> st/results/all-branch-statuses.txt indicating our seabios branch is up to > >> >> >> date I expect this is the case. > >> >> >> > >> >> >> There is some risk to this, but SeaBIOS gets a fairly small number of > >> >> >> changes so the stable branches do not stray too far from master in general > >> >> >> so I think this approach is fine. > >> >> >> > >> >> >> IOW it would be fine to push upstreams 1.9-stable to our repo along with > >> >> >> the rel-1.9.1 tag and to then apply this patch. > >> >> >> > >> >> > > >> >> > Makes sense. > >> >> > > >> >> > >> >> ping? > >> >> > >> > > >> > With my recently acquired seabios maintainer hat on: > >> > > >> > Acked-by: Wei Liu > >> > > >> > One of the committers will need to pick this up to do the actual push. > >> > >> I can't see a rel-1.9.1 tag yet in the repo on xenbits, so - are you > >> sure? > >> > > > > That's what I meant -- a committer needs to fetch from upstream tree > > then push the tag to our own seabios tree before applying this patch. > > > > The upstream tree is at git://git.seabios.org/seabios.git . > > > > If you can handle that, it would be great. :-) > > I'd rather leave this to someone being a better friend with git > than I am, so Ian, maybe you could do this? > This is fine. It's not very urgent anyway. > Ultimately I think you, Wei, should really have commit rights > on that particular tree, to efficiently fulfill your role as its > maintainer. This works for me, too. Wei. > > Jan >