From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v3 09/23] xsplice: Add support for bug
	frames. (v4)
Date: Wed, 24 Feb 2016 11:26:16 -0500
Message-ID: <20160224162616.GB25409@char.us.oracle.com>
References: <1455300361-13092-1-git-send-email-konrad.wilk@oracle.com>
	<1455300361-13092-10-git-send-email-konrad.wilk@oracle.com>
	<56C37A04.6030501@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <konrad@char.us.oracle.com>) id 1aYcGr-0007iC-9X
	for xen-devel@lists.xenproject.org; Wed, 24 Feb 2016 16:26:37 +0000
Content-Disposition: inline
In-Reply-To: <56C37A04.6030501@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, jinsong.liu@alibaba-inc.com, xen-devel@lists.xen.org, mpohlack@amazon.de, ross.lagerwall@citrix.com, Stefano Stabellini <stefano.stabellini@citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org, sasha.levin@citrix.com
List-Id: xen-devel@lists.xenproject.org

On Tue, Feb 16, 2016 at 07:35:32PM +0000, Andrew Cooper wrote:
> On 12/02/16 18:05, Konrad Rzeszutek Wilk wrote:
> > diff --git a/xen/common/symbols.c b/xen/common/symbols.c
> > index a59c59d..bf5623f 100644
> > --- a/xen/common/symbols.c
> > +++ b/xen/common/symbols.c
> > @@ -17,6 +17,7 @@
> >  #include <xen/lib.h>
> >  #include <xen/string.h>
> >  #include <xen/spinlock.h>
> > +#include <xen/xsplice.h>
> >  #include <public/platform.h>
> >  #include <xen/guest_access.h>
> >  
> > @@ -101,6 +102,12 @@ bool_t is_active_kernel_text(unsigned long addr)
> >              (system_state < SYS_STATE_active && is_kernel_inittext(addr)));
> >  }
> >  
> > +bool_t is_active_text(unsigned long addr)
> > +{
> > +    return is_active_kernel_text(addr) ||
> > +           is_active_module_text(addr);
> > +}
> 
> This would be better as a static inline in a header file, to avoid a
> call into a separate translation unit.

I stuck it in kernel.h, as so, would that work for you?

diff --git a/xen/include/xen/kernel.h b/xen/include/xen/kernel.h
index 548b64d..1e8ed68 100644
--- a/xen/include/xen/kernel.h
+++ b/xen/include/xen/kernel.h
@@ -100,5 +100,20 @@ extern enum system_state {
 
 bool_t is_active_kernel_text(unsigned long addr);
 
+#ifdef CONFIG_XSPLICE
+#include <xen/xsplice.h>
+
+static bool_t is_active_text(unsigned long addr)
+{
+    return is_active_kernel_text(addr) ||
+           is_active_patch_text(addr);
+}
+#else
+static bool_t is_active_text(unsigned long addr)
+{
+    return is_active_kernel_text(addr);
+}
+#endif
+
 #endif /* _LINUX_KERNEL_H */