xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
	david.vrabel@citrix.com
Subject: Re: [PATCH 1/2] hvc_xen: add earlycon support
Date: Wed, 24 Feb 2016 12:18:43 -0500	[thread overview]
Message-ID: <20160224171842.GA9463@char.us.oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1602241550050.17248@kaball.uk.xensource.com>

> I could do the same here by dropping the if (!xen_pv_domain()) check
> above, but then if somebody specifies earlyprintk=xenboot on a non-Xen
> environment, I expect Linux would crash.

Nah, you made it "Work" with:
commit eb5ef07151ba3c3cb4bcef0c8f146ff1115eaa55
Author: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Date:   Fri Jan 27 18:31:36 2012 +0000

    hvc_xen: support PV on HVM consoles

But this patch:

commit 04b772d2b819f0dda2163e3193fa7cd447a6245c

xen/hvc: If we use xen_raw_printk let it also work on HVM guests.
    
    The xen_raw_printk works great for debugging purposes. We use
    for PV guests and we can also use it for HVM guests.
    
    However, for HVM guests we have a fallback of using the 0xe9
    port in case the hypervisor does not support an HVM guest of
    using the console_io hypercall. As such lets use 0xe9 during
    early bootup, and once the hyper-page is setup and if the
    console_io hypercall is supported - use that. Otherwise we
    will fallback to using the 0xe9 after early bootup.
    
    We also alter the return value for dom0_write_console to return
    an error value instead of zero. The HVC API has been supporting
    returning error values for quite some time.
    
    P.S.
    To use (and to see the output in the Xen ring buffer) one has to build
    the hypervisor with 'debug=y'.

Should make it possible for HVM guests to actually work with HVM x86 guests
if tweaked.

  reply	other threads:[~2016-02-24 17:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 12:22 [0/2] hvc_xen: fix xenboot on x86 and export to ARM Stefano Stabellini
2016-02-24 12:23 ` [PATCH 1/2] hvc_xen: add earlycon support Stefano Stabellini
2016-02-24 14:43   ` Boris Ostrovsky
2016-02-24 15:55     ` Stefano Stabellini
2016-02-24 17:18       ` Konrad Rzeszutek Wilk [this message]
2016-02-24 17:22         ` [Xen-devel] " Andrew Cooper
2016-02-25 12:00           ` Stefano Stabellini
2016-02-25 11:53         ` Stefano Stabellini
2016-02-24 12:23 ` [PATCH 2/2] hvc_xen: fix xenboot for DomUs Stefano Stabellini
2016-02-24 12:53   ` kbuild test robot
2016-02-24 15:48     ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160224171842.GA9463@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).