From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 8/8] tools/xenalyze: Actually handle case where number of ipi vectors exceeds static max
Date: Mon, 29 Feb 2016 11:16:33 -0500 [thread overview]
Message-ID: <20160229161633.GD21983@char.us.oracle.com> (raw)
In-Reply-To: <22224.18032.589353.128388@mariner.uk.xensource.com>
On Fri, Feb 26, 2016 at 12:34:56PM +0000, Ian Jackson wrote:
> George Dunlap writes ("[PATCH 8/8] tools/xenalyze: Actually handle case where number of ipi vectors exceeds static max"):
> > find_vec() is supposed to find the vector in the list if it exists,
> > choose an empty slot if it doesn't exist, and return null if all slots
> > are full.
> >
> > However, coverity noticed that although the callers of find_vec() handle
> > the last condition, find_vec() itself didn't.
> >
> > Check to see if we actually found an empty slot before attempting to
> > initialize it.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
applied.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-02-29 16:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 14:48 [PATCH 0/8] Fixes to Coverity issues reported on xenalyze George Dunlap
2016-02-25 14:48 ` [PATCH 1/8] tools/xenalyze: Close symbol_file after reading it George Dunlap
2016-02-26 12:22 ` Ian Jackson
2016-02-29 16:11 ` Konrad Rzeszutek Wilk
2016-02-25 14:48 ` [PATCH 2/8] tools/xenalyze: Avoid redundant check George Dunlap
2016-02-26 12:23 ` Ian Jackson
2016-02-29 16:15 ` Konrad Rzeszutek Wilk
2016-02-25 14:48 ` [PATCH 3/8] tools/xenalyze: Handle fstat errors properly George Dunlap
2016-02-26 12:25 ` Ian Jackson
2016-03-03 12:28 ` George Dunlap
2016-02-25 14:48 ` [PATCH 4/8] tools/xenalyze: Mark unreachable code as unreachable George Dunlap
2016-02-25 15:03 ` Ian Campbell
2016-02-25 15:09 ` George Dunlap
2016-02-25 15:28 ` Ian Campbell
2016-02-25 15:43 ` George Dunlap
2016-02-25 15:52 ` Ian Campbell
2016-02-26 12:28 ` Ian Jackson
2016-02-25 14:49 ` [PATCH 5/8] tools/xenalyze: Fix check for error return value George Dunlap
2016-02-26 12:29 ` Ian Jackson
2016-02-29 16:16 ` Konrad Rzeszutek Wilk
2016-02-25 14:49 ` [PATCH 6/8] tools/xenalyze: Fix off-by-one in MAX_CPUS range checks George Dunlap
2016-02-26 12:30 ` Ian Jackson
2016-02-29 16:58 ` George Dunlap
2016-03-03 12:44 ` George Dunlap
2016-02-25 14:49 ` [PATCH 7/8] tools/xenalyze: Fix multiple instances of *HYPERCALL_MAX George Dunlap
2016-02-26 12:33 ` Ian Jackson
2016-02-29 17:29 ` George Dunlap
2016-03-01 13:36 ` Ian Jackson
2016-02-25 14:49 ` [PATCH 8/8] tools/xenalyze: Actually handle case where number of ipi vectors exceeds static max George Dunlap
2016-02-26 12:34 ` Ian Jackson
2016-02-29 16:16 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229161633.GD21983@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=george.dunlap@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).