From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH v3 01/16] libxc: Rework extra module initialisation Date: Tue, 1 Mar 2016 11:51:26 +0000 Message-ID: <20160301115126.GL17111@citrix.com> References: <1456412174-20162-1-git-send-email-anthony.perard@citrix.com> <1456412174-20162-2-git-send-email-anthony.perard@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1456412174-20162-2-git-send-email-anthony.perard@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Anthony PERARD Cc: Wei Liu , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBGZWIgMjUsIDIwMTYgYXQgMDI6NTU6NTlQTSArMDAwMCwgQW50aG9ueSBQRVJBUkQg d3JvdGU6Cj4gVGhpcyBwYXRjaCB1c2UgeGNfZG9tX2FsbG9jX3NlZ21lbnQoKSB0byBhbGxvY2F0 ZSB0aGUgbWVtb3J5IHNwYWNlIGZvciB0aGUKPiBBQ1BJIG1vZHVsZXMgYW5kIHRoZSBTTUJJT1Mg bW9kdWxlcy4gVGhpcyBpcyB0byByZXBsYWNlIHRoZSBhcmJpdHJhcnkKPiBwbGFjZW1lbnQgb2Yg MU1CIGFmdGVyIHRoZSBodm1sb2FkZXIgaW1hZ2UuCj4gCj4gSW4gbGF0ZXIgcGF0Y2hlcywgd2hp bGUgdHJ5aW5nIHRvIGxvYWQgYSBmaXJtd2FyZSBzdWNoIGFzIE9WTUYsIHRoZSBsYXRlcgo+IGNv dWxkIGVhc2lseSBiZSBsb2FkZWQgcGFzdCB0aGUgYWRkcmVzcyA0TUIgKE9WTUYgaXMgYSAyTUIg YmluYXJ5KSwgYnV0Cj4gaHZtbG9hZGVyIHVzZSBhIHJhbmdlIG9mIG1lbW9yeSBmcm9tIDRNQiB0 byA4TUIgdG8gcGVyZm9ybSB0ZXN0cyBhbmQgaW4gdGhlCj4gcHJvY2VzcywgY2xlYXIgdGhlIG1l bW9yeSwgYmVmb3JlIGxvYWRpbmcgdGhlIG1vZHVsZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogQW50 aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+Cgo+IC0tLQo+IE5ldyBwYXRj aCBpbiBWMy4KPiAtLS0KPiAgdG9vbHMvbGlieGMveGNfZG9tX2h2bWxvYWRlci5jIHwgMTI0ICsr KysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCAzMSBpbnNlcnRpb25zKCspLCA5MyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvdG9v bHMvbGlieGMveGNfZG9tX2h2bWxvYWRlci5jIGIvdG9vbHMvbGlieGMveGNfZG9tX2h2bWxvYWRl ci5jCj4gaW5kZXggMzMwZDVlOC4uNTRlMDk2YyAxMDA2NDQKPiAtLS0gYS90b29scy9saWJ4Yy94 Y19kb21faHZtbG9hZGVyLmMKPiArKysgYi90b29scy9saWJ4Yy94Y19kb21faHZtbG9hZGVyLmMK PiBAQCAtMTI5LDk4ICsxMjksNDUgQEAgc3RhdGljIGVsZl9lcnJvcnN0YXR1cyB4Y19kb21fcGFy c2VfaHZtX2tlcm5lbChzdHJ1Y3QgeGNfZG9tX2ltYWdlICpkb20pCj4gICAgICByZXR1cm4gcmM7 Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgbW9kdWxlc19pbml0KHN0cnVjdCB4Y19kb21faW1hZ2Ug KmRvbSwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgdWludDY0X3QgdmVuZCwgc3RydWN0IGVs Zl9iaW5hcnkgKmVsZiwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgdWludDY0X3QgKm1zdGFy dF9vdXQsIHVpbnQ2NF90ICptZW5kX291dCkKPiArc3RhdGljIGludCBtb2R1bGVfaW5pdF9vbmUo c3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICBz dHJ1Y3QgeGNfaHZtX2Zpcm13YXJlX21vZHVsZSAqbW9kdWxlLAo+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICBjaGFyICpuYW1lKQo+ICB7Cj4gLSNkZWZpbmUgTU9EVUxFX0FMSUdOIDFVTCA8 PCA3Cj4gLSNkZWZpbmUgTUJfQUxJR04gICAgIDFVTCA8PCAyMAo+IC0jZGVmaW5lIE1LQUxJR04o eCwgYSkgKCgodWludDY0X3QpKHgpICsgKGEpIC0gMSkgJiB+KHVpbnQ2NF90KSgoYSkgLSAxKSkK PiAtICAgIHVpbnQ2NF90IHRvdGFsX2xlbiA9IDAsIG9mZnNldDEgPSAwOwo+ICsgICAgc3RydWN0 IHhjX2RvbV9zZWcgc2VnOwo+ICsgICAgdm9pZCAqZGVzdDsKPiAgCj4gLSAgICBpZiAoIGRvbS0+ YWNwaV9tb2R1bGUubGVuZ3RoID09IDAgJiYgZG9tLT5zbWJpb3NfbW9kdWxlLmxlbmd0aCA9PSAw ICkKPiAtICAgICAgICByZXR1cm4gMDsKPiAtCj4gLSAgICAvKiBGaW5kIHRoZSB0b3RhbCBsZW5n dGggZm9yIHRoZSBmaXJtd2FyZSBtb2R1bGVzIHdpdGggYSByZWFzb25hYmxlIGxhcmdlCj4gLSAg ICAgKiBhbGlnbm1lbnQgc2l6ZSB0byBhbGlnbiBlYWNoIHRoZSBtb2R1bGVzLgo+IC0gICAgICov Cj4gLSAgICB0b3RhbF9sZW4gPSBNS0FMSUdOKGRvbS0+YWNwaV9tb2R1bGUubGVuZ3RoLCBNT0RV TEVfQUxJR04pOwo+IC0gICAgb2Zmc2V0MSA9IHRvdGFsX2xlbjsKPiAtICAgIHRvdGFsX2xlbiAr PSBNS0FMSUdOKGRvbS0+c21iaW9zX21vZHVsZS5sZW5ndGgsIE1PRFVMRV9BTElHTik7Cj4gLQo+ IC0gICAgLyogV2FudCB0byBwbGFjZSB0aGUgbW9kdWxlcyAxTWIrY2hhbmdlIGJlaGluZCB0aGUg bG9hZGVyIGltYWdlLiAqLwo+IC0gICAgKm1zdGFydF9vdXQgPSBNS0FMSUdOKGVsZi0+cGVuZCwg TUJfQUxJR04pICsgKE1CX0FMSUdOKTsKPiAtICAgICptZW5kX291dCA9ICptc3RhcnRfb3V0ICsg dG90YWxfbGVuOwo+IC0KPiAtICAgIGlmICggKm1lbmRfb3V0ID4gdmVuZCApCj4gLSAgICAgICAg cmV0dXJuIC0xOwo+IC0KPiAtICAgIGlmICggZG9tLT5hY3BpX21vZHVsZS5sZW5ndGggIT0gMCAp Cj4gLSAgICAgICAgZG9tLT5hY3BpX21vZHVsZS5ndWVzdF9hZGRyX291dCA9ICptc3RhcnRfb3V0 Owo+IC0gICAgaWYgKCBkb20tPnNtYmlvc19tb2R1bGUubGVuZ3RoICE9IDAgKQo+IC0gICAgICAg IGRvbS0+c21iaW9zX21vZHVsZS5ndWVzdF9hZGRyX291dCA9ICptc3RhcnRfb3V0ICsgb2Zmc2V0 MTsKPiArICAgIGlmICggbW9kdWxlLT5sZW5ndGggKQo+ICsgICAgewo+ICsgICAgICAgIGlmICgg eGNfZG9tX2FsbG9jX3NlZ21lbnQoZG9tLCAmc2VnLCBuYW1lLCAwLCBtb2R1bGUtPmxlbmd0aCkg KQo+ICsgICAgICAgICAgICBnb3RvIGVycjsKPiArICAgICAgICBkZXN0ID0geGNfZG9tX3NlZ190 b19wdHIoZG9tLCAmc2VnKTsKPiArICAgICAgICBpZiAoIGRlc3QgPT0gTlVMTCApCj4gKyAgICAg ICAgewo+ICsgICAgICAgICAgICBET01QUklOVEYoIiVzOiB4Y19kb21fc2VnX3RvX3B0cihkb20s ICZzZWcpID0+IE5VTEwiLAo+ICsgICAgICAgICAgICAgICAgICAgICAgX19GVU5DVElPTl9fKTsK PiArICAgICAgICAgICAgZ290byBlcnI7Cj4gKyAgICAgICAgfQo+ICsgICAgICAgIG1lbWNweShk ZXN0LCBtb2R1bGUtPmRhdGEsIG1vZHVsZS0+bGVuZ3RoKTsKPiArICAgICAgICBtb2R1bGUtPmd1 ZXN0X2FkZHJfb3V0ID0gc2VnLnZzdGFydDsKCk9uZSB0aGluZyB5b3UgbWlnaHQgd2FudCB0byB0 YWtlIGNhcmUgaXMgdGhhdCB0aGUgZ3Vlc3RfYWRkcl9vdXQgaXMKYWN0dWFsbHkgd2l0aGluIGEg cmVhc29uYWJsZSByYW5nZSB0aGF0IGh2bWxvYWRlciBjYW4gYWNjZXNzPwoKCldlaS4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWls aW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVu LWRldmVsCg==