From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Doug Goldstein <cardoe@cardoe.com>,
Xen-devel <xen-devel@lists.xen.org>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH 4/4] hvmloader: Use xen/errno.h rather than the host systems errno.h
Date: Thu, 3 Mar 2016 11:35:28 +0000 [thread overview]
Message-ID: <20160303113528.GA5535@citrix.com> (raw)
In-Reply-To: <1456858641-20776-4-git-send-email-andrew.cooper3@citrix.com>
On Tue, Mar 01, 2016 at 06:57:21PM +0000, Andrew Cooper wrote:
> hvmloader is unhosted, and shouldn't use the system errno.h. It already has
> to use Xen's errno.h for other hypercalls. The use of public/io/xs_wire.h
> requires the use of un-prefixed errno values.
>
> This fixes the build on stricter toolchains where requesting -fno-builtin does
> reduce the include path as much as it can.
>
> Reported-by: Doug Goldstein <cardoe@cardoe.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-03 11:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 18:57 [PATCH 1/4] xen/errno: Introduce EISDIR/EROFS/ENOTEMPTY to the ABI Andrew Cooper
2016-03-01 18:57 ` [PATCH 2/4] xen/errno: Declare aliases using XEN_ERRNO() Andrew Cooper
2016-03-02 2:38 ` Doug Goldstein
2016-03-01 18:57 ` [PATCH 3/4] xen/errno: Reduce complexity of inclusion Andrew Cooper
2016-03-02 2:39 ` Doug Goldstein
2016-03-03 8:30 ` Jan Beulich
2016-03-03 14:14 ` [PATCH v3] " Andrew Cooper
2016-03-04 12:24 ` Jan Beulich
2016-03-04 12:28 ` Jan Beulich
2016-03-04 12:50 ` Andrew Cooper
2016-03-04 13:05 ` Jan Beulich
2016-03-04 16:07 ` Ian Jackson
2016-03-07 15:13 ` [PATCH v4] " Andrew Cooper
2016-03-01 18:57 ` [PATCH 4/4] hvmloader: Use xen/errno.h rather than the host systems errno.h Andrew Cooper
2016-03-02 12:53 ` Doug Goldstein
2016-03-03 11:35 ` Wei Liu [this message]
2016-03-02 2:37 ` [PATCH 1/4] xen/errno: Introduce EISDIR/EROFS/ENOTEMPTY to the ABI Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303113528.GA5535@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).