From: Konrad Rzeszutek Wilk <konrad@kernel.org>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 3/3] travis: actually disable debug for non-debug
Date: Mon, 7 Mar 2016 10:32:57 -0500 [thread overview]
Message-ID: <20160307153257.GB5351@localhost.localdomain> (raw)
In-Reply-To: <1457122188-7389-3-git-send-email-cardoe@cardoe.com>
On Fri, Mar 04, 2016 at 02:09:48PM -0600, Doug Goldstein wrote:
> Non-debug builds need to explicitly disable debug due to debug being
> defaulted to y in Config.mk
Which is because by default staging has debug=y (this changes once
the rcX candidates become available).
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> ---
> CC: Ian Jackson <ian.jackson@eu.citrix.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Keir Fraser <keir@xen.org>
> CC: Tim Deegan <tim@xen.org>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
>
> change since v1:
> - none
>
> tested at: https://travis-ci.org/cardoe/xen/builds/113700670
> this run shows a failure with BIGMEM=y and debug=n which was only exposed
> by this change.
> ---
> .travis.yml | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 4bcd5a0..741a8ab 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -11,33 +11,33 @@ branches:
> matrix:
> include:
> - compiler: gcc
> - env: XEN_TARGET_ARCH=x86_64
> + env: XEN_TARGET_ARCH=x86_64 debug=n
> - compiler: gcc
> - env: XEN_TARGET_ARCH=x86_64 XEN_CONFIG_EXPERT=y RANDCONFIG=y
> + env: XEN_TARGET_ARCH=x86_64 XEN_CONFIG_EXPERT=y RANDCONFIG=y debug=n
> - compiler: gcc-5
> - env: XEN_TARGET_ARCH=x86_64
> + env: XEN_TARGET_ARCH=x86_64 debug=n
> - compiler: gcc
> env: XEN_TARGET_ARCH=x86_64 debug=y
> - compiler: gcc-5
> env: XEN_TARGET_ARCH=x86_64 debug=y
> - compiler: clang
> - env: XEN_TARGET_ARCH=x86_64 clang=y
> + env: XEN_TARGET_ARCH=x86_64 clang=y debug=n
> - compiler: clang-3.8
> - env: XEN_TARGET_ARCH=x86_64 clang=y
> + env: XEN_TARGET_ARCH=x86_64 clang=y debug=n
> - compiler: clang
> env: XEN_TARGET_ARCH=x86_64 clang=y debug=y
> - compiler: clang-3.8
> env: XEN_TARGET_ARCH=x86_64 clang=y debug=y
> - compiler: gcc
> - env: XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabihf-
> + env: XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabihf- debug=n
> - compiler: gcc
> - env: XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabihf- XEN_CONFIG_EXPERT=y RANDCONFIG=y
> + env: XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabihf- XEN_CONFIG_EXPERT=y RANDCONFIG=y debug=n
> - compiler: gcc
> env: XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabihf- debug=y
> - compiler: gcc
> - env: XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
> + env: XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- debug=n
> - compiler: gcc
> - env: XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- XEN_CONFIG_EXPERT=y RANDCONFIG=y
> + env: XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- XEN_CONFIG_EXPERT=y RANDCONFIG=y debug=n
> - compiler: gcc
> env: XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- debug=y
> addons:
> --
> 2.4.10
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-07 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 20:09 [PATCH v2 1/3] travis: skip building coverity, smoke, and master Doug Goldstein
2016-03-04 20:09 ` [PATCH v2 2/3] travis: use matching C++ for GCC version Doug Goldstein
2016-03-04 20:09 ` [PATCH v2 3/3] travis: actually disable debug for non-debug Doug Goldstein
2016-03-07 15:32 ` Konrad Rzeszutek Wilk [this message]
2016-03-07 15:18 ` [PATCH v2 1/3] travis: skip building coverity, smoke, and master Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307153257.GB5351@localhost.localdomain \
--to=konrad@kernel.org \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).