From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH 3/7] oxenstored: refactor request processing Date: Tue, 29 Mar 2016 17:38:08 +0100 Message-ID: <20160329163808.GA1024@citrix.com> References: <1458237075-13777-1-git-send-email-jonathan.davies@citrix.com> <1458237075-13777-4-git-send-email-jonathan.davies@citrix.com> <56F468A5.9080609@oracle.com> <56F46EFA.9060204@citrix.com> <56F47EEA.3070103@oracle.com> <20160329090829.GE3316@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akwf6-0006FR-OI for xen-devel@lists.xenproject.org; Tue, 29 Mar 2016 16:38:36 +0000 Content-Disposition: inline In-Reply-To: <20160329090829.GE3316@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jonathan Davies Cc: Wei Liu , Andrew Cooper , Jon Ludlam , Euan Harris , Dave Scott , xen-devel@lists.xenproject.org, Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBNYXIgMjksIDIwMTYgYXQgMTA6MDg6MzBBTSArMDEwMCwgSm9uYXRoYW4gRGF2aWVz IHdyb3RlOgo+IE9uIFRodSwgTWFyIDI0LCAyMDE2IGF0IDA3OjU3OjMwUE0gLTA0MDAsIEJvcmlz IE9zdHJvdnNreSB3cm90ZToKPiA+IE9uIDAzLzI0LzIwMTYgMDY6NDkgUE0sIEFuZHJldyBDb29w ZXIgd3JvdGU6Cj4gPiA+T24gMjQvMDMvMjAxNiAyMjoyMiwgQm9yaXMgT3N0cm92c2t5IHdyb3Rl Ogo+ID4gPj5PbiAwMy8xNy8yMDE2IDAxOjUxIFBNLCBKb25hdGhhbiBEYXZpZXMgd3JvdGU6Cj4g PiA+Pj5FbmNhcHN1bGF0ZSB0aGUgcmVxdWVzdCBpbiBhIHJlY29yZCB0aGF0IGlzIHBhc3NlZCBm cm9tIGRvX2lucHV0IHRvCj4gPiA+Pj5wcm9jZXNzX3BhY2tldCBhbmQgaW5wdXRfaGFuZGxlX2Vy cm9yLgo+ID4gPj4+Cj4gPiA+Pj5UaGlzIHdpbGwgYmUgaGVscGZ1bCB3aGVuIGtlZXBpbmcgdHJh Y2sgb2YgdGhlIHJlcXVlc3RzIG1hZGUgYXMgcGFydAo+ID4gPj4+b2YgYQo+ID4gPj4+dHJhbnNh Y3Rpb24uCj4gPiA+Pj4KPiA+ID4+PlNpZ25lZC1vZmYtYnk6IEpvbmF0aGFuIERhdmllcyA8am9u YXRoYW4uZGF2aWVzQGNpdHJpeC5jb20+Cj4gPiA+Pj5SZXZpZXdlZC1ieTogQW5kcmV3IENvb3Bl ciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KPiA+ID4+PlJldmlld2VkLWJ5OiBKb24gTHVk bGFtIDxqb25hdGhhbi5sdWRsYW1AY2l0cml4LmNvbT4KPiA+ID4+PlJldmlld2VkLWJ5OiBFdWFu IEhhcnJpcyA8ZXVhbi5oYXJyaXNAY2l0cml4LmNvbT4KPiA+ID4+Pi0tLQo+ID4gPj4+ICAgdG9v bHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3MubWwgfCAgIDE1ICsrKysrKysrKystLS0tLQo+ID4g Pj4+ICAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4g PiA+Pj4KPiA+ID4+PmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5t bAo+ID4gPj4+Yi90b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbAo+ID4gPj4+aW5kZXgg N2E3MzY2OS4uYzkyYmVjNyAxMDA2NDQKPiA+ID4+Pi0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3Jl ZC9wcm9jZXNzLm1sCj4gPiA+Pj4rKysgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5t bAo+ID4gPj4+QEAgLTM0NCwxMSArMzQ0LDExIEBAIGxldCBmdW5jdGlvbl9vZl90eXBlIHR5ID0K PiA+ID4+PiAgICAgICB8IFhlbmJ1cy5YYi5PcC5JbnZhbGlkICAgICAgICAgICAtPiByZXBseV9h Y2sgZG9fZXJyb3IKPiA+ID4+PiAgICAgICB8IF8gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAtPiByZXBseV9hY2sgZG9fZXJyb3IKPiA+ID4+PiAgIC1sZXQgaW5wdXRfaGFuZGxlX2Vycm9y IH5jb25zIH5kb21zIH5mY3QgfnR5IH5jb24gfnQgfnJpZCB+ZGF0YSA9Cj4gPiA+Pj4rbGV0IGlu cHV0X2hhbmRsZV9lcnJvciB+Y29ucyB+ZG9tcyB+ZmN0IH5jb24gfnQgfnJlcSA9Cj4gPiA+Pj4g ICAgICAgbGV0IHJlcGx5X2Vycm9yIGUgPQo+ID4gPj4+ICAgICAgICAgICBQYWNrZXQuRXJyb3Ig ZSBpbgo+ID4gPj4+ICAgICAgIHRyeQo+ID4gPj4+LSAgICAgICAgZmN0IGNvbiB0IGRvbXMgY29u cyBkYXRhCj4gPiA+Pj4rICAgICAgICBmY3QgY29uIHQgZG9tcyBjb25zIHJlcS5QYWNrZXQuZGF0 YQo+ID4gPj4+ICAgICAgIHdpdGgKPiA+ID4+PiAgICAgICB8IERlZmluZS5JbnZhbGlkX3BhdGgg ICAgICAgICAgLT4gcmVwbHlfZXJyb3IgIkVJTlZBTCIKPiA+ID4+PiAgICAgICB8IERlZmluZS5B bHJlYWR5X2V4aXN0ICAgICAgICAgLT4gcmVwbHlfZXJyb3IgIkVFWElTVCIKPiA+ID4+PkBAIC0z NzAsNyArMzcwLDEwIEBAIGxldCBpbnB1dF9oYW5kbGVfZXJyb3IgfmNvbnMgfmRvbXMgfmZjdCB+ dHkgfmNvbgo+ID4gPj4+fnQgfnJpZCB+ZGF0YSA9Cj4gPiA+Pj4gICAoKioKPiA+ID4+PiAgICAq IE5vdGhyb3cgZ3VhcmFudGVlLgo+ID4gPj4+ICAgICopCj4gPiA+Pj4tbGV0IHByb2Nlc3NfcGFj a2V0IH5zdG9yZSB+Y29ucyB+ZG9tcyB+Y29uIH50aWQgfnJpZCB+dHkgfmRhdGEgPQo+ID4gPj4+ K2xldCBwcm9jZXNzX3BhY2tldCB+c3RvcmUgfmNvbnMgfmRvbXMgfmNvbiB+cmVxID0KPiA+ID4+ PisgICAgbGV0IHR5ID0gcmVxLlBhY2tldC50eSBpbgo+ID4gPj4+KyAgICBsZXQgdGlkID0gcmVx LlBhY2tldC50aWQgaW4KPiA+ID4+PisgICAgbGV0IHJpZCA9IHJlcS5QYWNrZXQucmlkIGluCj4g PiA+Pj4gICAgICAgdHJ5Cj4gPiA+Pj4gICAgICAgICAgIGxldCBmY3QgPSBmdW5jdGlvbl9vZl90 eXBlIHR5IGluCj4gPiA+Pj4gICAgICAgICAgIGxldCB0ID0KPiA+ID4+PkBAIC0zNzksNyArMzgy LDcgQEAgbGV0IHByb2Nlc3NfcGFja2V0IH5zdG9yZSB+Y29ucyB+ZG9tcyB+Y29uIH50aWQKPiA+ ID4+Pn5yaWQgfnR5IH5kYXRhID0KPiA+ID4+PiAgICAgICAgICAgICAgIGVsc2UKPiA+ID4+PiAg ICAgICAgICAgICAgICAgICBDb25uZWN0aW9uLmdldF90cmFuc2FjdGlvbiBjb24gdGlkCj4gPiA+ Pj4gICAgICAgICAgICAgICBpbgo+ID4gPj4+LSAgICAgICAgbGV0IHJlc3BvbnNlID0gaW5wdXRf aGFuZGxlX2Vycm9yIH5jb25zIH5kb21zIH5mY3QgfnR5IH5jb24KPiA+ID4+Pn50IH5yaWQgfmRh dGEgaW4KPiA+ID4+PisgICAgICAgIGxldCByZXNwb25zZSA9IGlucHV0X2hhbmRsZV9lcnJvciB+ Y29ucyB+ZG9tcyB+ZmN0IH5jb24gfnQKPiA+ID4+Pn5yZXEgaW4KPiA+ID4+PiAgICAgICAgICAg ICAoKiBQdXQgdGhlIHJlc3BvbnNlIG9uIHRoZSB3aXJlICopCj4gPiA+Pj4gICAgICAgICAgIHNl bmRfcmVzcG9uc2UgdHkgY29uIHQgcmlkIHJlc3BvbnNlCj4gPiA+Pj5AQCAtNDEyLDExICs0MTUs MTMgQEAgbGV0IGRvX2lucHV0IHN0b3JlIGNvbnMgZG9tcyBjb24gPQo+ID4gPj4+ICAgICAgIGlm IG5ld3BhY2tldCB0aGVuICgKPiA+ID4+PiAgICAgICAgICAgbGV0IHBhY2tldCA9IENvbm5lY3Rp b24ucG9wX2luIGNvbiBpbgo+ID4gPj4+ICAgICAgICAgICBsZXQgdGlkLCByaWQsIHR5LCBkYXRh ID0gWGVuYnVzLlhiLlBhY2tldC51bnBhY2sgcGFja2V0IGluCj4gPiA+Pj4rICAgICAgICBsZXQg cmVxID0ge1BhY2tldC50aWQ7IFBhY2tldC5yaWQ7IFBhY2tldC50eTsgUGFja2V0LmRhdGF9IGlu Cj4gPiA+Pj4rCj4gPiA+PkkgdGhpbmsgdGhpcyBjaGFuZ2UgYnJlYWtzIHRoZSBidWlsZCB3aXRo IG9sZGVyIG9jYW1sIHZlcnNpb25zOgo+ID4gPj4KPiA+ID4+cm9vdEBoYXN3ZWxsPiBvY2FtbG9w dCAtdgo+ID4gPj5UaGUgT0NhbWwgbmF0aXZlLWNvZGUgY29tcGlsZXIsIHZlcnNpb24gNC4wMC4x Cj4gPiA+PlN0YW5kYXJkIGxpYnJhcnkgZGlyZWN0b3J5OiAvdXNyL2xpYjY0L29jYW1sCj4gPiA+ PnJvb3RAaGFzd2VsbD4gb2NhbWxvcHQgLWcgLWNjb3B0ICIgICAgIiAtZHR5cGVzIC1JCj4gPiA+ Pi9yb290L3RtcC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xpYnMveGIgLUkKPiA+ID4+ L3Jvb3QvdG1wL3hlbi90b29scy9vY2FtbC94ZW5zdG9yZWQvLi4vbGlicy9tbWFwIC1JCj4gPiA+ Pi9yb290L3RtcC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xpYnMveGMgLUkKPiA+ID4+ L3Jvb3QvdG1wL3hlbi90b29scy9vY2FtbC94ZW5zdG9yZWQvLi4vbGlicy9ldmVudGNobiAtY2Mg Z2NjIC13IEYKPiA+ID4+LXdhcm4tZXJyb3IgRiAtYyAtbyBwcm9jZXNzLmNteCBwcm9jZXNzLm1s Cj4gPiA+PnJvb3RAaGFzd2VsbD4KPiA+ID4+Cj4gPiA+Pgo+ID4gPj5yb290QG92czEwND4gb2Nh bWxvcHQgLXYKPiA+ID4+VGhlIE9iamVjdGl2ZSBDYW1sIG5hdGl2ZS1jb2RlIGNvbXBpbGVyLCB2 ZXJzaW9uIDMuMTEuMgo+ID4gPj5TdGFuZGFyZCBsaWJyYXJ5IGRpcmVjdG9yeTogL3Vzci9saWI2 NC9vY2FtbAo+ID4gPj5yb290QG92czEwND4gb2NhbWxvcHQgLWcgLWNjb3B0ICIgICAgIiAtZHR5 cGVzIC1JCj4gPiA+Pi9yb290L3RtcC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xpYnMv eGIgLUkKPiA+ID4+L3Jvb3QvdG1wL3hlbi90b29scy9vY2FtbC94ZW5zdG9yZWQvLi4vbGlicy9t bWFwIC1JCj4gPiA+Pi9yb290L3RtcC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xpYnMv eGMgLUkKPiA+ID4+L3Jvb3QvdG1wL3hlbi90b29scy9vY2FtbC94ZW5zdG9yZWQvLi4vbGlicy9l dmVudGNobiAtY2MgZ2NjIC13IEYKPiA+ID4+LXdhcm4tZXJyb3IgRiAtYyAtbyBwcm9jZXNzLmNt eCBwcm9jZXNzLm1sCj4gPiA+PkZpbGUgInByb2Nlc3MubWwiLCBsaW5lIDQ4NywgY2hhcmFjdGVy cyAyMy0yNDoKPiA+ID4+RXJyb3I6IFN5bnRheCBlcnJvcgo+ID4gPj5yb290QG92czEwND4KPiA+ ID4+Cj4gPiA+PkkgZG9uJ3Qga25vdyBtdWNoIGFib3V0IG9jYW1sIChPSywgSSBrbm93ICpub3Ro aW5nKiBhYm91dCBvY2FtbCkgc28gSQo+ID4gPj5jYW4ndCBzYXkgd2hhdCBleGFjdGx5IG1pZ2h0 IGJlIHdyb25nLgo+ID4gPkNvdWxkIHlvdSBwZXJoYXBzIHRyeSB0aGlzIGluc3RlYWQ/Cj4gPiA+ Cj4gPiA+bGV0IHJlcSA9IHt0aWQgPSBQYWNrZXQudGlkOyByaWQgPSBQYWNrZXQucmlkOyB0eSA9 IFBhY2tldC50eTsgZGF0YSA9Cj4gPiA+UGFja2V0LmRhdGF9IGluCj4gPiA+Cj4gPiA+SXQgaXMg bW9zdCBsaWtlbHkgdGhhdCB0aGUgb2xkZXIgdmVyc2lvbiBvZiBPY2FtbCBjYW4ndCBpbmZlciB0 aGUgb3JkZXIKPiA+ID5vZiBmaWVsZHMuCj4gPiA+Cj4gPiA+fkFuZHJldwo+ID4gCj4gPiAKPiA+ IE5vLCBpdCBub3cgZ2l2ZXMgbWUgIkVycm9yOiBVbmJvdW5kIHJlY29yZCBmaWVsZCBsYWJlbCB0 aWQiCj4gPiAKPiA+IC1ib3Jpcwo+IAo+IEFuZHJldydzIGd1ZXNzIHdhcyBjbG9zZSwgYnV0IHRo ZSB3cm9uZyB3YXkgYXJvdW5kIC0tIHBsZWFzZSBjb3VsZCB5b3UgdHJ5IHRoZQo+IGZvbGxvd2lu ZyB3aXRoIHRoZSBvbGRlciBjb21waWxlcj8KPiAKPiBsZXQgcmVxID0ge1BhY2tldC50aWQ9dGlk OyBQYWNrZXQucmlkPXJpZDsgUGFja2V0LnR5PXR5OyBQYWNrZXQuZGF0YT1kYXRhfSBpbgo+IAo+ IEkgd2FzIHVzaW5nIGEgc3ludGFjdGljIGZlYXR1cmUgb2YgT0NhbWwgY2FsbGVkICdmaWVsZCBw dW5uaW5nJyB3aGljaCBpcwo+IGdlbmVyYWxseSBjb25zaWRlcmVkIGdvb2QgcHJhY3RpY2UgYW5k IG1ha2VzIGZvciBtb3JlIHJlYWRhYmxlIGNvZGUuIEl0IGxvb2tzCj4gbGlrZSB0aGlzIGZlYXR1 cmUgd2FzIGludHJvZHVjZWQgaW4gT0NhbWwgMy4xMi4wIChkYXRpbmcgZnJvbSAyMDEwKSwgd2hp Y2ggaXMKPiBjb25zaXN0ZW50IHdpdGggQm9yaXMnIGZpbmRpbmdzLgo+IAo+IFdoYXQncyB0aGUg cG9saWN5IGhlcmUgLS0gaXMgdGhlcmUgYSBkZWZpbmVkIHZlcnNpb24gb2YgdGhlIE9DYW1sIGNv bXBpbGVyIHdoaWNoCj4gdG9vbHMvb2NhbWwgbmVlZHMgdG8gYmUgYWJsZSB0byBjb21waWxlIHdp dGg/CgpJdCBpcyBub3QgZXhwbGljaXRseSBsaXN0ZWQgaW4gUkVBRE1FIG9yIElOU1RBTEwuIFRo ZSBvY2FtbCB0b29scwptYWludGFpbmVyIChEYXZlIGluIHRoaXMgY2FzZSkgaXMgd2VsY29tZSB0 byBwcm92aWRlIHRoZSBtaW5pbXVtIHZlcnNpb24KcmVxdWlyZWQuCgpNZWFud2hpbGUsIEkgZG9u J3QgdGhpbmsgd2Ugc2hvdWxkIGJyZWFrIGV4aXN0aW5nIGJ1aWxkIHdpdGhvdXQgcGlubmluZwpk b3duIHRoZSBtaW5pbXVtIHJlcXVpcmVkIHZlcnNpb24gZmlyc3QsIHNvIHdlIHNob3VsZCBmaXgg Qm9yaXMncwpicmVha2FnZS4gIFRoZSBmaXggc2VlbXMgc2ltcGxlIGVub3VnaCBhbnl3YXkuCgpX ZWkuCgo+IAo+IFRoYW5rcywKPiBKb25hdGhhbgo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCj4gWGVuLWRldmVsIG1haWxpbmcgbGlzdAo+IFhlbi1k ZXZlbEBsaXN0cy54ZW4ub3JnCj4gaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFp bGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hl bi1kZXZlbAo=