From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Davies Subject: Re: [PATCH 3/7] oxenstored: refactor request processing Date: Wed, 30 Mar 2016 16:46:58 +0100 Message-ID: <20160330154658.GF3316@citrix.com> References: <1458237075-13777-1-git-send-email-jonathan.davies@citrix.com> <1458237075-13777-4-git-send-email-jonathan.davies@citrix.com> <56F468A5.9080609@oracle.com> <56F46EFA.9060204@citrix.com> <56F47EEA.3070103@oracle.com> <20160329090829.GE3316@citrix.com> <20160329163808.GA1024@citrix.com> <7516EF85-27A6-4A86-BEAE-1B7090B31BC3@recoil.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1alISm-0006Mk-Cs for xen-devel@lists.xenproject.org; Wed, 30 Mar 2016 15:55:20 +0000 Content-Disposition: inline In-Reply-To: <7516EF85-27A6-4A86-BEAE-1B7090B31BC3@recoil.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: David Scott Cc: Wei Liu , Andrew Cooper , Jon Ludlam , Euan Harris , xen-devel@lists.xenproject.org, Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBNYXIgMjksIDIwMTYgYXQgMDg6NDE6NTRQTSArMDEwMCwgRGF2aWQgU2NvdHQgd3Jv dGU6Cj4gCj4gPiBPbiAyOSBNYXIgMjAxNiwgYXQgMTc6MzgsIFdlaSBMaXUgPHdlaS5saXUyQGNp dHJpeC5jb20+IHdyb3RlOgo+ID4gCj4gPiBPbiBUdWUsIE1hciAyOSwgMjAxNiBhdCAxMDowODoz MEFNICswMTAwLCBKb25hdGhhbiBEYXZpZXMgd3JvdGU6Cj4gPj4gT24gVGh1LCBNYXIgMjQsIDIw MTYgYXQgMDc6NTc6MzBQTSAtMDQwMCwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOgo+ID4+PiBPbiAw My8yNC8yMDE2IDA2OjQ5IFBNLCBBbmRyZXcgQ29vcGVyIHdyb3RlOgo+ID4+Pj4gT24gMjQvMDMv MjAxNiAyMjoyMiwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOgo+ID4+Pj4+IE9uIDAzLzE3LzIwMTYg MDE6NTEgUE0sIEpvbmF0aGFuIERhdmllcyB3cm90ZToKPiA+Pj4+Pj4gRW5jYXBzdWxhdGUgdGhl IHJlcXVlc3QgaW4gYSByZWNvcmQgdGhhdCBpcyBwYXNzZWQgZnJvbSBkb19pbnB1dCB0bwo+ID4+ Pj4+PiBwcm9jZXNzX3BhY2tldCBhbmQgaW5wdXRfaGFuZGxlX2Vycm9yLgo+ID4+Pj4+PiAKPiA+ Pj4+Pj4gVGhpcyB3aWxsIGJlIGhlbHBmdWwgd2hlbiBrZWVwaW5nIHRyYWNrIG9mIHRoZSByZXF1 ZXN0cyBtYWRlIGFzIHBhcnQKPiA+Pj4+Pj4gb2YgYQo+ID4+Pj4+PiB0cmFuc2FjdGlvbi4KPiA+ Pj4+Pj4gCj4gPj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEpvbmF0aGFuIERhdmllcyA8am9uYXRoYW4u ZGF2aWVzQGNpdHJpeC5jb20+Cj4gPj4+Pj4+IFJldmlld2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxh bmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgo+ID4+Pj4+PiBSZXZpZXdlZC1ieTogSm9uIEx1ZGxh bSA8am9uYXRoYW4ubHVkbGFtQGNpdHJpeC5jb20+Cj4gPj4+Pj4+IFJldmlld2VkLWJ5OiBFdWFu IEhhcnJpcyA8ZXVhbi5oYXJyaXNAY2l0cml4LmNvbT4KPiA+Pj4+Pj4gLS0tCj4gPj4+Pj4+ICB0 b29scy9vY2FtbC94ZW5zdG9yZWQvcHJvY2Vzcy5tbCB8ICAgMTUgKysrKysrKysrKy0tLS0tCj4g Pj4+Pj4+ICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkK PiA+Pj4+Pj4gCj4gPj4+Pj4+IGRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQvcHJv Y2Vzcy5tbAo+ID4+Pj4+PiBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC9wcm9jZXNzLm1sCj4gPj4+ Pj4+IGluZGV4IDdhNzM2NjkuLmM5MmJlYzcgMTAwNjQ0Cj4gPj4+Pj4+IC0tLSBhL3Rvb2xzL29j YW1sL3hlbnN0b3JlZC9wcm9jZXNzLm1sCj4gPj4+Pj4+ICsrKyBiL3Rvb2xzL29jYW1sL3hlbnN0 b3JlZC9wcm9jZXNzLm1sCj4gPj4+Pj4+IEBAIC0zNDQsMTEgKzM0NCwxMSBAQCBsZXQgZnVuY3Rp b25fb2ZfdHlwZSB0eSA9Cj4gPj4+Pj4+ICAgICAgfCBYZW5idXMuWGIuT3AuSW52YWxpZCAgICAg ICAgICAgLT4gcmVwbHlfYWNrIGRvX2Vycm9yCj4gPj4+Pj4+ICAgICAgfCBfICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgLT4gcmVwbHlfYWNrIGRvX2Vycm9yCj4gPj4+Pj4+ICAtbGV0IGlu cHV0X2hhbmRsZV9lcnJvciB+Y29ucyB+ZG9tcyB+ZmN0IH50eSB+Y29uIH50IH5yaWQgfmRhdGEg PQo+ID4+Pj4+PiArbGV0IGlucHV0X2hhbmRsZV9lcnJvciB+Y29ucyB+ZG9tcyB+ZmN0IH5jb24g fnQgfnJlcSA9Cj4gPj4+Pj4+ICAgICAgbGV0IHJlcGx5X2Vycm9yIGUgPQo+ID4+Pj4+PiAgICAg ICAgICBQYWNrZXQuRXJyb3IgZSBpbgo+ID4+Pj4+PiAgICAgIHRyeQo+ID4+Pj4+PiAtICAgICAg ICBmY3QgY29uIHQgZG9tcyBjb25zIGRhdGEKPiA+Pj4+Pj4gKyAgICAgICAgZmN0IGNvbiB0IGRv bXMgY29ucyByZXEuUGFja2V0LmRhdGEKPiA+Pj4+Pj4gICAgICB3aXRoCj4gPj4+Pj4+ICAgICAg fCBEZWZpbmUuSW52YWxpZF9wYXRoICAgICAgICAgIC0+IHJlcGx5X2Vycm9yICJFSU5WQUwiCj4g Pj4+Pj4+ICAgICAgfCBEZWZpbmUuQWxyZWFkeV9leGlzdCAgICAgICAgIC0+IHJlcGx5X2Vycm9y ICJFRVhJU1QiCj4gPj4+Pj4+IEBAIC0zNzAsNyArMzcwLDEwIEBAIGxldCBpbnB1dF9oYW5kbGVf ZXJyb3IgfmNvbnMgfmRvbXMgfmZjdCB+dHkgfmNvbgo+ID4+Pj4+PiB+dCB+cmlkIH5kYXRhID0K PiA+Pj4+Pj4gICgqKgo+ID4+Pj4+PiAgICogTm90aHJvdyBndWFyYW50ZWUuCj4gPj4+Pj4+ICAg KikKPiA+Pj4+Pj4gLWxldCBwcm9jZXNzX3BhY2tldCB+c3RvcmUgfmNvbnMgfmRvbXMgfmNvbiB+ dGlkIH5yaWQgfnR5IH5kYXRhID0KPiA+Pj4+Pj4gK2xldCBwcm9jZXNzX3BhY2tldCB+c3RvcmUg fmNvbnMgfmRvbXMgfmNvbiB+cmVxID0KPiA+Pj4+Pj4gKyAgICBsZXQgdHkgPSByZXEuUGFja2V0 LnR5IGluCj4gPj4+Pj4+ICsgICAgbGV0IHRpZCA9IHJlcS5QYWNrZXQudGlkIGluCj4gPj4+Pj4+ ICsgICAgbGV0IHJpZCA9IHJlcS5QYWNrZXQucmlkIGluCj4gPj4+Pj4+ICAgICAgdHJ5Cj4gPj4+ Pj4+ICAgICAgICAgIGxldCBmY3QgPSBmdW5jdGlvbl9vZl90eXBlIHR5IGluCj4gPj4+Pj4+ICAg ICAgICAgIGxldCB0ID0KPiA+Pj4+Pj4gQEAgLTM3OSw3ICszODIsNyBAQCBsZXQgcHJvY2Vzc19w YWNrZXQgfnN0b3JlIH5jb25zIH5kb21zIH5jb24gfnRpZAo+ID4+Pj4+PiB+cmlkIH50eSB+ZGF0 YSA9Cj4gPj4+Pj4+ICAgICAgICAgICAgICBlbHNlCj4gPj4+Pj4+ICAgICAgICAgICAgICAgICAg Q29ubmVjdGlvbi5nZXRfdHJhbnNhY3Rpb24gY29uIHRpZAo+ID4+Pj4+PiAgICAgICAgICAgICAg aW4KPiA+Pj4+Pj4gLSAgICAgICAgbGV0IHJlc3BvbnNlID0gaW5wdXRfaGFuZGxlX2Vycm9yIH5j b25zIH5kb21zIH5mY3QgfnR5IH5jb24KPiA+Pj4+Pj4gfnQgfnJpZCB+ZGF0YSBpbgo+ID4+Pj4+ PiArICAgICAgICBsZXQgcmVzcG9uc2UgPSBpbnB1dF9oYW5kbGVfZXJyb3IgfmNvbnMgfmRvbXMg fmZjdCB+Y29uIH50Cj4gPj4+Pj4+IH5yZXEgaW4KPiA+Pj4+Pj4gICAgICAgICAgICAoKiBQdXQg dGhlIHJlc3BvbnNlIG9uIHRoZSB3aXJlICopCj4gPj4+Pj4+ICAgICAgICAgIHNlbmRfcmVzcG9u c2UgdHkgY29uIHQgcmlkIHJlc3BvbnNlCj4gPj4+Pj4+IEBAIC00MTIsMTEgKzQxNSwxMyBAQCBs ZXQgZG9faW5wdXQgc3RvcmUgY29ucyBkb21zIGNvbiA9Cj4gPj4+Pj4+ICAgICAgaWYgbmV3cGFj a2V0IHRoZW4gKAo+ID4+Pj4+PiAgICAgICAgICBsZXQgcGFja2V0ID0gQ29ubmVjdGlvbi5wb3Bf aW4gY29uIGluCj4gPj4+Pj4+ICAgICAgICAgIGxldCB0aWQsIHJpZCwgdHksIGRhdGEgPSBYZW5i dXMuWGIuUGFja2V0LnVucGFjayBwYWNrZXQgaW4KPiA+Pj4+Pj4gKyAgICAgICAgbGV0IHJlcSA9 IHtQYWNrZXQudGlkOyBQYWNrZXQucmlkOyBQYWNrZXQudHk7IFBhY2tldC5kYXRhfSBpbgo+ID4+ Pj4+PiArCj4gPj4+Pj4gSSB0aGluayB0aGlzIGNoYW5nZSBicmVha3MgdGhlIGJ1aWxkIHdpdGgg b2xkZXIgb2NhbWwgdmVyc2lvbnM6Cj4gPj4+Pj4gCj4gPj4+Pj4gcm9vdEBoYXN3ZWxsPiBvY2Ft bG9wdCAtdgo+ID4+Pj4+IFRoZSBPQ2FtbCBuYXRpdmUtY29kZSBjb21waWxlciwgdmVyc2lvbiA0 LjAwLjEKPiA+Pj4+PiBTdGFuZGFyZCBsaWJyYXJ5IGRpcmVjdG9yeTogL3Vzci9saWI2NC9vY2Ft bAo+ID4+Pj4+IHJvb3RAaGFzd2VsbD4gb2NhbWxvcHQgLWcgLWNjb3B0ICIgICAgIiAtZHR5cGVz IC1JCj4gPj4+Pj4gL3Jvb3QvdG1wL3hlbi90b29scy9vY2FtbC94ZW5zdG9yZWQvLi4vbGlicy94 YiAtSQo+ID4+Pj4+IC9yb290L3RtcC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xpYnMv bW1hcCAtSQo+ID4+Pj4+IC9yb290L3RtcC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xp YnMveGMgLUkKPiA+Pj4+PiAvcm9vdC90bXAveGVuL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC8uLi9s aWJzL2V2ZW50Y2huIC1jYyBnY2MgLXcgRgo+ID4+Pj4+IC13YXJuLWVycm9yIEYgLWMgLW8gcHJv Y2Vzcy5jbXggcHJvY2Vzcy5tbAo+ID4+Pj4+IHJvb3RAaGFzd2VsbD4KPiA+Pj4+PiAKPiA+Pj4+ PiAKPiA+Pj4+PiByb290QG92czEwND4gb2NhbWxvcHQgLXYKPiA+Pj4+PiBUaGUgT2JqZWN0aXZl IENhbWwgbmF0aXZlLWNvZGUgY29tcGlsZXIsIHZlcnNpb24gMy4xMS4yCj4gPj4+Pj4gU3RhbmRh cmQgbGlicmFyeSBkaXJlY3Rvcnk6IC91c3IvbGliNjQvb2NhbWwKPiA+Pj4+PiByb290QG92czEw ND4gb2NhbWxvcHQgLWcgLWNjb3B0ICIgICAgIiAtZHR5cGVzIC1JCj4gPj4+Pj4gL3Jvb3QvdG1w L3hlbi90b29scy9vY2FtbC94ZW5zdG9yZWQvLi4vbGlicy94YiAtSQo+ID4+Pj4+IC9yb290L3Rt cC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xpYnMvbW1hcCAtSQo+ID4+Pj4+IC9yb290 L3RtcC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xpYnMveGMgLUkKPiA+Pj4+PiAvcm9v dC90bXAveGVuL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC8uLi9saWJzL2V2ZW50Y2huIC1jYyBnY2Mg LXcgRgo+ID4+Pj4+IC13YXJuLWVycm9yIEYgLWMgLW8gcHJvY2Vzcy5jbXggcHJvY2Vzcy5tbAo+ ID4+Pj4+IEZpbGUgInByb2Nlc3MubWwiLCBsaW5lIDQ4NywgY2hhcmFjdGVycyAyMy0yNDoKPiA+ Pj4+PiBFcnJvcjogU3ludGF4IGVycm9yCj4gPj4+Pj4gcm9vdEBvdnMxMDQ+Cj4gPj4+Pj4gCj4g Pj4+Pj4gSSBkb24ndCBrbm93IG11Y2ggYWJvdXQgb2NhbWwgKE9LLCBJIGtub3cgKm5vdGhpbmcq IGFib3V0IG9jYW1sKSBzbyBJCj4gPj4+Pj4gY2FuJ3Qgc2F5IHdoYXQgZXhhY3RseSBtaWdodCBi ZSB3cm9uZy4KPiA+Pj4+IENvdWxkIHlvdSBwZXJoYXBzIHRyeSB0aGlzIGluc3RlYWQ/Cj4gPj4+ PiAKPiA+Pj4+IGxldCByZXEgPSB7dGlkID0gUGFja2V0LnRpZDsgcmlkID0gUGFja2V0LnJpZDsg dHkgPSBQYWNrZXQudHk7IGRhdGEgPQo+ID4+Pj4gUGFja2V0LmRhdGF9IGluCj4gPj4+PiAKPiA+ Pj4+IEl0IGlzIG1vc3QgbGlrZWx5IHRoYXQgdGhlIG9sZGVyIHZlcnNpb24gb2YgT2NhbWwgY2Fu J3QgaW5mZXIgdGhlIG9yZGVyCj4gPj4+PiBvZiBmaWVsZHMuCj4gPj4+PiAKPiA+Pj4+IH5BbmRy ZXcKPiA+Pj4gCj4gPj4+IAo+ID4+PiBObywgaXQgbm93IGdpdmVzIG1lICJFcnJvcjogVW5ib3Vu ZCByZWNvcmQgZmllbGQgbGFiZWwgdGlkIgo+ID4+PiAKPiA+Pj4gLWJvcmlzCj4gPj4gCj4gPj4g QW5kcmV3J3MgZ3Vlc3Mgd2FzIGNsb3NlLCBidXQgdGhlIHdyb25nIHdheSBhcm91bmQgLS0gcGxl YXNlIGNvdWxkIHlvdSB0cnkgdGhlCj4gPj4gZm9sbG93aW5nIHdpdGggdGhlIG9sZGVyIGNvbXBp bGVyPwo+ID4+IAo+ID4+IGxldCByZXEgPSB7UGFja2V0LnRpZD10aWQ7IFBhY2tldC5yaWQ9cmlk OyBQYWNrZXQudHk9dHk7IFBhY2tldC5kYXRhPWRhdGF9IGluCj4gPj4gCj4gPj4gSSB3YXMgdXNp bmcgYSBzeW50YWN0aWMgZmVhdHVyZSBvZiBPQ2FtbCBjYWxsZWQgJ2ZpZWxkIHB1bm5pbmcnIHdo aWNoIGlzCj4gPj4gZ2VuZXJhbGx5IGNvbnNpZGVyZWQgZ29vZCBwcmFjdGljZSBhbmQgbWFrZXMg Zm9yIG1vcmUgcmVhZGFibGUgY29kZS4gSXQgbG9va3MKPiA+PiBsaWtlIHRoaXMgZmVhdHVyZSB3 YXMgaW50cm9kdWNlZCBpbiBPQ2FtbCAzLjEyLjAgKGRhdGluZyBmcm9tIDIwMTApLCB3aGljaCBp cwo+ID4+IGNvbnNpc3RlbnQgd2l0aCBCb3JpcycgZmluZGluZ3MuCj4gPj4gCj4gPj4gV2hhdCdz IHRoZSBwb2xpY3kgaGVyZSAtLSBpcyB0aGVyZSBhIGRlZmluZWQgdmVyc2lvbiBvZiB0aGUgT0Nh bWwgY29tcGlsZXIgd2hpY2gKPiA+PiB0b29scy9vY2FtbCBuZWVkcyB0byBiZSBhYmxlIHRvIGNv bXBpbGUgd2l0aD8KPiA+IAo+ID4gSXQgaXMgbm90IGV4cGxpY2l0bHkgbGlzdGVkIGluIFJFQURN RSBvciBJTlNUQUxMLiBUaGUgb2NhbWwgdG9vbHMKPiA+IG1haW50YWluZXIgKERhdmUgaW4gdGhp cyBjYXNlKSBpcyB3ZWxjb21lIHRvIHByb3ZpZGUgdGhlIG1pbmltdW0gdmVyc2lvbgo+ID4gcmVx dWlyZWQuCj4gPiAKPiA+IE1lYW53aGlsZSwgSSBkb24ndCB0aGluayB3ZSBzaG91bGQgYnJlYWsg ZXhpc3RpbmcgYnVpbGQgd2l0aG91dCBwaW5uaW5nCj4gPiBkb3duIHRoZSBtaW5pbXVtIHJlcXVp cmVkIHZlcnNpb24gZmlyc3QsIHNvIHdlIHNob3VsZCBmaXggQm9yaXMncwo+ID4gYnJlYWthZ2Uu ICBUaGUgZml4IHNlZW1zIHNpbXBsZSBlbm91Z2ggYW55d2F5Lgo+IAo+IEl0IGxvb2tzIGxpa2Ug dGhlIGZpeCBpcyBzbWFsbCBhbmQgZWFzeSDigJQgSSB0aGluayB0aGlzIGlzIGdvb2QgZm9yIG5v dy4KPiAKPiBMZXTigJlzIHBvc3Rwb25lIHJlcXVpcmluZyBhIGxhdGVyIE9DYW1sIHZlcnNpb24g dW50aWwgd2UgcmVhbGx5IG5lZWQgYSBmZWF0dXJlIG9ubHkgcHJlc2VudCBpbiBhIGxhdGVyIHZl cnNpb24uIEkgc3VzcGVjdCB0aGlzIHdpbGwgaGFwcGVuIGV2ZW50dWFsbHksIHByb2JhYmx5IHdo ZW4gd2UgdHJ5IHRvIGFkZCBhIGRlcGVuZGVuY3kgKGUuZy4gZnJvbSB0aGUgTWlyYWdlIHdvcmxk KSB3aGljaCByZXF1aXJlcyA0LjAyKy4KCk9LOyBzb3VuZHMgc2Vuc2libGUuCgpTaW5jZSB0aGUg b3JpZ2luYWwgcGF0Y2ggaGFzIGFscmVhZHkgYmVlbiBjb21taXR0ZWQgdG8gc3RhZ2luZywgSSBw cmVzdW1lIHlvdSdkCmxpa2UgbWUgdG8gZm9ybWFsbHkgc3VibWl0IGEgc3RhbmRhbG9uZSBwYXRj aCB0aGF0IGZpeGVzIHRoaXMgaXNzdWUuIEkgd2lsbCBwb3N0Cml0IHNlcGFyYXRlbHkuCgpJZiBJ J20gd3JvbmcgYW5kIHlvdSdkIGxpa2UgbWUgdG8gcG9zdCBhIHYyIG9mIHRoZSB3aG9sZSBzZXJp ZXMsIGxldCBtZSBrbm93LgoKVGhhbmtzLApKb25hdGhhbgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2 ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK