From: Wei Liu <wei.liu2@citrix.com>
To: "Xu, Quan" <quan.xu@intel.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Daniel De Graaf <dgdegra@tycho.nsa.gov>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH RFC v1 09/14] Makefile: delete STUBDOMPATH target
Date: Thu, 31 Mar 2016 14:49:41 +0100 [thread overview]
Message-ID: <20160331134941.GA18159@citrix.com> (raw)
In-Reply-To: <945CA011AD5F084CBEA3E851C0AB28894B8737BD@SHSMSX101.ccr.corp.intel.com>
On Thu, Mar 31, 2016 at 10:21:22AM +0000, Xu, Quan wrote:
> On March 11, 2016 12:53am, Wei Liu <wei.liu2@citrix.com> wrote:
> > -build: $(STUBDOMPATH)
> > +build: $(STUBDOM_BUILD)
>
> Wei,
> in original code, in stubdom/vtpm and stubdom/vtpmmgr, the code style is inconsistent and ugly.
> Do you have any plan to fix them? :)
>
No, I don't.
> btw, if the others(or me) want to fix the code style, how to fix it? send out a big patch? Any suggestions?
> Thanks.:)
>
I personally prefer small patches in a series, but I don't object to
having large patch(es) either. At the end of the day, I think Daniel's
opinion matters most. After a plan is agreed upon, you can then provide
a branch for us to pull in. Note that upstream don't test vtpm in any
fashion so you do need to run your tests.
The only thing that matters to me is that when you will do it -- you
will need to patch a different tree after I split off stubdom. In order
to minimise the fuss one of us will need to wait for the other.
Wei.
>
> Quan
>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-31 13:49 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 16:46 [RFC PATCH v1] Splitting off stubdom to a different tree Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 0/6] xen: split stubdom from xen.git Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 1/6] config: don't hard-code mini-os path Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 2/6] tools: use "?=" to set XEN_ROOT in Makefile Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 3/6] libxc: use $XEN_ROOT to reference libelf in xen Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 4/6] libxl: generate and install stubdompath.sh Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 5/6] Unhook stubdom from build system Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 6/6] Remove stubdom directory Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 00/14] stubdom: split stubdom from xen.git Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 01/14] Import more files " Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 02/14] Makefile: introduce dist target Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 03/14] Add a gitignore Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 04/14] Makefile: require XEN_ROOT and MINI_OS to be defined Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 05/14] Makefile: replace MINI_OS with MINIOS_ROOT Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 06/14] pciutils: don't use hard-coded XEN_ROOT Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 07/14] grub: " Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 08/14] Makefile: export STUBDOM_ROOT Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 09/14] Makefile: delete STUBDOMPATH target Wei Liu
2016-03-31 10:21 ` Xu, Quan
2016-03-31 13:49 ` Wei Liu [this message]
2016-04-01 1:41 ` Xu, Quan
2016-04-01 10:03 ` Wei Liu
2016-04-06 9:09 ` Xu, Quan
2016-04-06 9:39 ` Wei Liu
2016-04-25 14:27 ` Wei Liu
2016-07-05 13:53 ` Xu, Quan
2016-07-05 13:57 ` Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 10/14] Makefile: require QEMU_ROOT to be defined Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 11/14] Makefile: always include Config.mk from xen source tree Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 12/14] Makefile: delete ioemu directory in clean target Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 13/14] Makefile: fix removing *.mk Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 14/14] Add README file Wei Liu
2016-03-10 18:33 ` Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 0/2] mini-os: split stubdom from xen.git Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 1/2] Config.mk: use MINI_OS if specified Wei Liu
2016-03-10 16:52 ` [PATCH RFC v1 2/2] Makefile: introduce STUBDOM_ROOT Wei Liu
2016-03-15 0:20 ` [RFC PATCH v1] Splitting off stubdom to a different tree Samuel Thibault
2016-03-15 12:30 ` Wei Liu
2016-03-15 14:22 ` Wei Liu
2016-03-15 18:26 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331134941.GA18159@citrix.com \
--to=wei.liu2@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=quan.xu@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).