From: Wei Liu <wei.liu2@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org,
Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH 1/4] libxl: set the device model version earlier in xenstore
Date: Fri, 8 Apr 2016 14:14:39 +0100 [thread overview]
Message-ID: <20160408131439.GH32191@citrix.com> (raw)
In-Reply-To: <1460051129-20817-2-git-send-email-roger.pau@citrix.com>
On Thu, Apr 07, 2016 at 07:45:26PM +0200, Roger Pau Monne wrote:
> So libxl doesn't have to pass the build info around just to get the device
> model used by the guest. This allows to simplify
> libxl__device_nic_setdefault.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
I have some reservation on this approach. I would rather passing around
a struct than accessing xenstore. The latter is much more expensive.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-08 13:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 17:45 [PATCH 0/4] libxl: fix CDROM issues Roger Pau Monne
2016-04-07 17:45 ` [PATCH 1/4] libxl: set the device model version earlier in xenstore Roger Pau Monne
2016-04-08 13:14 ` Wei Liu [this message]
2016-04-08 14:16 ` Roger Pau Monné
2016-04-08 14:24 ` Wei Liu
2016-04-07 17:45 ` [PATCH 2/4] libxl: set the backend type to Qdisk for CDROM devices on DM HVM guests Roger Pau Monne
2016-04-08 13:29 ` Wei Liu
2016-04-07 17:45 ` [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert} Roger Pau Monne
2016-04-08 13:21 ` Wei Liu
2016-04-08 14:17 ` Roger Pau Monné
2016-04-08 14:25 ` Wei Liu
2016-04-08 14:34 ` Ian Jackson
2016-04-08 14:35 ` Roger Pau Monné
2016-04-08 14:47 ` Wei Liu
2016-04-08 14:51 ` Roger Pau Monné
2016-04-08 14:59 ` Andrew Cooper
2016-04-08 15:06 ` George Dunlap
2016-04-08 15:07 ` Wei Liu
2016-04-07 17:45 ` [PATCH 4/4] libxl: remove code added to use the 'phy' backend with CDROM devices Roger Pau Monne
2016-04-08 13:30 ` Wei Liu
2016-04-08 15:07 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160408131439.GH32191@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).