From: Wei Liu <wei.liu2@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v11 1/2] libxl: add support for vscsi
Date: Fri, 8 Apr 2016 15:23:28 +0100 [thread overview]
Message-ID: <20160408142328.GA6085@citrix.com> (raw)
In-Reply-To: <20160408141646.GA12197@aepfle.de>
On Fri, Apr 08, 2016 at 04:16:46PM +0200, Olaf Hering wrote:
> > > + goto out;
> > > +
> > > + tmp = libxl__xs_read(gc, t, GCSPRINTF("%s/%s/backend-id", fe_path, dir));
> > > + if (!tmp)
> > > + goto out;
> > > + ctrl->backend_domid = atoi(tmp);
> >
> > Please sanitise input coming from frontend. You need to check if the
> > backend domid and frontend domid make sense.
>
> What do you have in mind? Something like in vusb_be_from_xs_fe?
>
Yes.
Wei.
> Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-08 14:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 7:01 [PATCH v11 0/2] libxl: add support for pvscsi, iteration 11 Olaf Hering
2016-04-08 7:01 ` [PATCH v11 1/2] libxl: add support for vscsi Olaf Hering
2016-04-08 8:53 ` Juergen Gross
2016-04-08 10:18 ` Olaf Hering
2016-04-08 12:06 ` Wei Liu
2016-04-08 13:47 ` Ian Jackson
2016-04-08 14:49 ` Wei Liu
2016-04-08 14:16 ` Olaf Hering
2016-04-08 14:23 ` Wei Liu [this message]
2016-04-08 15:43 ` Olaf Hering
2016-04-11 12:57 ` Olaf Hering
2016-04-11 13:02 ` Wei Liu
2016-04-08 14:41 ` Wei Liu
2016-04-08 7:01 ` [PATCH v11 2/2] Scripts to create and delete xen-scsiback nodes in Linux target framework Olaf Hering
2016-04-08 11:05 ` Wei Liu
2016-04-08 11:07 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160408142328.GA6085@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).