From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen: change the sizes of fields in the HVM start info layout to be 64bits
Date: Fri, 8 Apr 2016 17:38:56 +0100 [thread overview]
Message-ID: <20160408163856.GE7377@citrix.com> (raw)
In-Reply-To: <5707EAB102000078000E6138@prv-mh.provo.novell.com>
On Fri, Apr 08, 2016 at 10:30:25AM -0600, Jan Beulich wrote:
> >>> On 08.04.16 at 18:01, <Ian.Jackson@eu.citrix.com> wrote:
> > Andrew Cooper writes ("Re: [PATCH] xen: change the sizes of fields in the HVM
> > start info layout to be 64bits"):
> >> On 08/04/16 16:47, Roger Pau Monne wrote:
> >> > At the moment the only consumer of this structure is x86, but other arches
> >> > might also use it, so make all the fields 64bits. On x86 Xen will still try
> >> > to place everything below the 4GiB boundary, but that might not be feasible
> >> > in other arches.
> >> >
> >> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >> > Requested-by: Jan Beulich <jbeulich@suse.com>
> >>
> >> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >>
> >> I hope never to need to use this for x86, but leaving some wiggleroom is
> >> probably best. If the very worst happens, the guest can just enable PAE
> >> paging to get access to the data.
> >
> > Thanks.
> >
> > Queued.
>
> And already applied as I see. I think rushing things in like this is
> not a solution, no matter that we want to freeze the tree today.
> Changes like this should be free to go in as de-facto bug fixes
> after the freeze date.
>
Yes, I'm fine with this changing after the freeze. I certainly don't
want to release a wrong interface.
Wei.
> Jan
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-08 16:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 15:47 [PATCH] xen: change the sizes of fields in the HVM start info layout to be 64bits Roger Pau Monne
2016-04-08 15:51 ` Wei Liu
2016-04-08 15:52 ` Andrew Cooper
2016-04-08 16:01 ` Ian Jackson
2016-04-08 16:30 ` Jan Beulich
2016-04-08 16:38 ` Wei Liu [this message]
2016-04-08 16:27 ` Jan Beulich
2016-04-08 16:31 ` Wei Liu
2016-04-08 16:32 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160408163856.GE7377@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).