From: Olaf Hering <olaf@aepfle.de>
To: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
George.Dunlap@eu.citrix.com, dario.faggioli@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xenproject.org,
roger.pau@citrix.com
Subject: Re: [PATCH v3 1/7] libxl: improve return codes for some pci related functions
Date: Wed, 20 Apr 2016 22:28:23 +0200 [thread overview]
Message-ID: <20160420202823.GB9937@gmail.com> (raw)
In-Reply-To: <1461139444-12342-2-git-send-email-paulinaszubarczyk@gmail.com>
On Wed, Apr 20, Paulina Szubarczyk wrote:
> *libxl__device_from_pcidev() initialize the values of libxl__device
> struct and can be void.
> -static int libxl__device_from_pcidev(libxl__gc *gc, uint32_t domid,
> +static void libxl__device_from_pcidev(libxl__gc *gc, uint32_t domid,
> libxl_device_pci *pcidev,
> libxl__device *device)
> {
> @@ -74,8 +74,6 @@ static int libxl__device_from_pcidev(libxl__gc *gc, uint32_t domid,
> device->devid = 0;
> device->domid = domid;
> device->kind = LIBXL__DEVICE_KIND_PCI;
> -
> - return 0;
If you dont have it on your radar already:
This should be done for all other functions of that type as well. I was
always wondering why they had to return something.
Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-20 20:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 8:03 [PATCH v3 00/10] xl: improve coding style and return more failure on Paulina Szubarczyk
2016-04-20 8:03 ` [PATCH v3 1/7] libxl: improve return codes for some pci related functions Paulina Szubarczyk
2016-04-20 20:28 ` Olaf Hering [this message]
2016-04-27 14:31 ` Wei Liu
2016-04-20 8:03 ` [PATCH v3 2/7] libxl: style cleanups in libxl_device_pci_assignable_list() Paulina Szubarczyk
2016-04-20 20:24 ` Olaf Hering
2016-04-21 7:17 ` Paulina Szubarczyk
2016-04-20 8:04 ` [PATCH v3 3/7] xl_cmdimpl: improve return codes for cd-insert commands Paulina Szubarczyk
2016-04-20 20:30 ` Olaf Hering
2016-04-20 8:04 ` [PATCH v3 4/7] xl_cmdimpl - Add return codes for pci-detach, pci-attach, pci-asssignable-add, and pci-assignable-remove Paulina Szubarczyk
2016-04-27 14:31 ` Wei Liu
2016-04-20 8:04 ` [PATCH v3 5/7] xl: improve main_tmem_* return codes Paulina Szubarczyk
2016-04-21 9:43 ` George Dunlap
2016-04-27 14:31 ` Wei Liu
2016-04-20 8:04 ` [PATCH v3 6/7] libxl: Fix libxl_set_memory_target return value Paulina Szubarczyk
2016-04-20 20:56 ` Olaf Hering
2016-04-27 14:29 ` Wei Liu
2016-05-09 8:21 ` Paulina Szubarczyk
2016-05-09 9:48 ` George Dunlap
2016-05-09 11:15 ` Wei Liu
2016-04-20 8:04 ` [PATCH v3 7/7] libxl: libxl_tmem functions improving coding style Paulina Szubarczyk
2016-04-20 21:04 ` Olaf Hering
2016-04-27 14:31 ` Wei Liu
2016-04-27 16:53 ` Dario Faggioli
2016-04-27 16:59 ` Wei Liu
2016-04-27 14:33 ` [PATCH v3 00/10] xl: improve coding style and return more failure on Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420202823.GB9937@gmail.com \
--to=olaf@aepfle.de \
--cc=George.Dunlap@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=paulinaszubarczyk@gmail.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).