From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86emul: don't allow INVLPG in real mode
Date: Fri, 22 Apr 2016 15:40:55 +0100 [thread overview]
Message-ID: <20160422144055.GN27627@citrix.com> (raw)
In-Reply-To: <571A4E9F02000078000E4D15@prv-mh.provo.novell.com>
On Fri, Apr 22, 2016 at 08:17:35AM -0600, Jan Beulich wrote:
> As both INVLPG and INVLPGA have basically the same exception rules
> (leaving aside that INVLPGA requires SVME enabled, which so far isn't
> being taken care of, and that INVLPG requires ModRM.mod != 3), fold
> the handling of the two as much as possible alongside achieving the
> goal of the patch (at once doing the #UD checks pror to the #GP one,
> which ought to be more in line with how hardware does things).
>
> But please note that AMD and Intel disagree on what exceptions INVLPG
> may raise, and the more reasonable Intel variant is being followed.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
So this patch supersedes Andrew's patch to fix invlpg on AMD with shadow
paging?
Ask because I have a list of things to track and not sure if this is
something new.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-22 14:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 14:17 [PATCH] x86emul: don't allow INVLPG in real mode Jan Beulich
2016-04-22 14:40 ` Wei Liu [this message]
2016-04-22 15:09 ` Jan Beulich
2016-04-22 16:08 ` Andrew Cooper
2016-04-25 7:28 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422144055.GN27627@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).