xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Keir Fraser <keir@xen.org>, Wei Liu <wei.liu2@citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/MSI-X: correctly track interrupt masking state
Date: Mon, 25 Apr 2016 12:29:04 +0100	[thread overview]
Message-ID: <20160425112904.GD11686@citrix.com> (raw)
In-Reply-To: <571E1A9B02000078000E548C@prv-mh.provo.novell.com>

On Mon, Apr 25, 2016 at 05:24:43AM -0600, Jan Beulich wrote:
> >>> On 22.04.16 at 18:35, <andrew.cooper3@citrix.com> wrote:
> > On 22/04/16 08:20, Jan Beulich wrote:
> >> When a guest unmasks MSI-X interrupts before enabling MSI-X on the
> >> device, so far nothing updates the {host,guest}_masked internal state;
> >> this to date only gets done when MSI-X is already enabled. This is why
> >> half way recent Linux works (as it enables MSI-X first), while Windows
> >> doesn't (as it enables MSI-X only after having set up und unmasked all
> >> vectors). Since with a successful write to the vector control field
> >> everything is ready internally, we should also update internal tracking
> >> state there, regardless of the device's MSI-X enabled state.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > 
> > Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 

Release-acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      reply	other threads:[~2016-04-25 11:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22  7:20 [PATCH] x86/MSI-X: correctly track interrupt masking state Jan Beulich
2016-04-22 16:35 ` Andrew Cooper
2016-04-25 11:24   ` Jan Beulich
2016-04-25 11:29     ` Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160425112904.GD11686@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).