From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Paul Durrant <paul.durrant@citrix.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] x86/HVM: slightly improve hvm_mmio_{first, last}_byte()
Date: Tue, 26 Apr 2016 11:34:47 +0100 [thread overview]
Message-ID: <20160426103447.GE20763@citrix.com> (raw)
In-Reply-To: <571F42C802000078000E5AAF@prv-mh.provo.novell.com>
On Tue, Apr 26, 2016 at 02:28:24AM -0600, Jan Beulich wrote:
> EFLAGS.DF can be assumed to be usually clear, so unlikely()-annotate
> the conditionals accordingly.
>
> Also prefer latching p->size (used twice) into a local variable, at
> once making it unnecessary for the reader to be sure expressions get
> evaluated left to right (operand promotion would yield a different
> result if p->addr + p->size - 1 was evaluted right to left).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-04-26 10:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 8:28 [PATCH] x86/HVM: slightly improve hvm_mmio_{first, last}_byte() Jan Beulich
2016-04-26 8:41 ` Paul Durrant
2016-04-26 8:46 ` Jan Beulich
2016-04-26 8:53 ` Paul Durrant
2016-04-26 10:34 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426103447.GE20763@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).