From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [RFC PATCH 7/7] build: convert lock_profile to Kconfig
Date: Mon, 2 May 2016 12:08:49 -0400 [thread overview]
Message-ID: <20160502160849.GB10856@char.us.oracle.com> (raw)
In-Reply-To: <1462162246-32413-8-git-send-email-cardoe@cardoe.com>
On Sun, May 01, 2016 at 11:10:46PM -0500, Doug Goldstein wrote:
> Convert the 'lock_profile' option to Kconfig as CONFIG_LOCK_PROFILE.
>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> ---
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien.grall@arm.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> INSTALL | 1 -
> xen/Kconfig.debug | 6 ++++++
> xen/Rules.mk | 2 --
> xen/arch/arm/xen.lds.S | 2 +-
> xen/arch/x86/domain.c | 2 +-
> xen/arch/x86/xen.lds.S | 2 +-
> xen/common/keyhandler.c | 2 +-
> xen/common/spinlock.c | 10 +++++-----
> xen/common/sysctl.c | 2 +-
> xen/include/xen/spinlock.h | 4 ++--
> 10 files changed, 18 insertions(+), 15 deletions(-)
>
> diff --git a/INSTALL b/INSTALL
> index 623887d..616a67a 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -227,7 +227,6 @@ VGABIOS_REL_DATE="dd Mon yyyy"
>
> The following variables can be used to tweak some aspects of the
> hypervisor build.
> -lock_profile=y
> lto=y
>
> During tools build external repos will be cloned into the source tree.
> diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
> index 4727273..5b370e8 100644
> --- a/xen/Kconfig.debug
> +++ b/xen/Kconfig.debug
> @@ -28,6 +28,12 @@ config FRAME_POINTER
> maybe slower, but it gives very useful debugging information
> in case of any Xen bugs.
>
> +config LOCK_PROFILE
> + bool "Lock Profiiling"
> + default n
> + ---help---
> + Lock Profiling
Would it make sense to also mention what tool one can use this with?
Perhaps:
"Lock profiling allows you to see how often locks are taken and blocked.
You can use serial console to print (and reset) using 'l' and 'L'
respectively, or the 'xenlockprof' tool.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-05-02 16:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 4:10 [RFC PATCH 0/7] Kconfig debug options Doug Goldstein
2016-05-02 4:10 ` [RFC PATCH 1/7] build: add debug menu to Kconfig Doug Goldstein
2016-05-02 10:42 ` Wei Liu
2016-05-02 11:02 ` Andrew Cooper
2016-05-02 14:35 ` Doug Goldstein
2016-05-02 4:10 ` [RFC PATCH 2/7] build: convert crash_debug " Doug Goldstein
2016-05-02 4:10 ` [RFC PATCH 3/7] build: convert verbose " Doug Goldstein
2016-05-02 15:18 ` Konrad Rzeszutek Wilk
2016-05-03 13:47 ` Doug Goldstein
2016-05-02 4:10 ` [RFC PATCH 4/7] build: convert frame_pointer " Doug Goldstein
2016-05-02 15:25 ` Konrad Rzeszutek Wilk
2016-05-02 15:56 ` Jan Beulich
2016-05-02 4:10 ` [RFC PATCH 5/7] build: wire up pre-existing debug build flag Doug Goldstein
2016-05-02 16:04 ` Konrad Rzeszutek Wilk
2016-05-02 4:10 ` [RFC PATCH 6/7] build: convert perfc{, _arrays} to Kconfig Doug Goldstein
2016-05-02 4:10 ` [RFC PATCH 7/7] build: convert lock_profile " Doug Goldstein
2016-05-02 16:08 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502160849.GB10856@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).