From: Wei Liu <wei.liu2@citrix.com>
To: Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
Kyle Temkin <ktemkin@binghamton.edu>,
sstabellini@kernel.org, "Kyle J. Temkin" <temkink@ainfosec.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] xen/arm64: ensure that the correct SP is used for exceptions
Date: Tue, 3 May 2016 14:37:47 +0100 [thread overview]
Message-ID: <20160503133747.GL14150@citrix.com> (raw)
In-Reply-To: <572880D6.3050201@arm.com>
On Tue, May 03, 2016 at 11:43:34AM +0100, Julien Grall wrote:
> (CC Wei for release-ack)
>
> Hello Kyle,
>
> On 28/04/16 18:14, Kyle Temkin wrote:
> >From: "Kyle J. Temkin" <temkink@ainfosec.com>
> >
> >The ARMv8 architecture has a SPSel ("stack pointer selection") machine
> >register that allows us to determine which exception level's stack
> >pointer is loaded when an exception occurs. As we don't want to
> >use the non-priveleged SP_EL0 stack pointer -- or even assume that SP_EL0
>
> NIT: s/priveleged/privileged/
>
> >points to a valid address in the hypervisor context-- we'll need to ensure
> >that our EL2 code sets the SPSel to SP_ELn mode, so exceptions that trap
> >to EL2 use the EL2 stack pointer.
> >
> >This corrects an issue that can manifest as a hang-on-IRQ on some
> >arm64 cores if the firmware/bootloader has previously initialized SPSel
> >to 0; in which case Xen's exceptions will incorrectly use an invalid SP_EL0,
> >and will endlessly spin on the synchronous abort handler.
> >
> >Signed-off-by: Kyle Temkin <temkink@ainfosec.com>
>
> Reviewed-by: Julien Grall <julien.grall@arm.com>
>
> Wei, this is a bug-fix and I think it should go to Xen 4.7.
>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
> We would also need to backport this patch on Xen 4.4 -> Xen 4.6.
>
> Regards,
>
> >---
> > xen/arch/arm/arm64/head.S | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> >diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> >index 946e2c9..d5831f2 100644
> >--- a/xen/arch/arm/arm64/head.S
> >+++ b/xen/arch/arm/arm64/head.S
> >@@ -361,6 +361,11 @@ skip_bss:
> > ldr x0, =(HSCTLR_BASE)
> > msr SCTLR_EL2, x0
> >
> >+ /* Ensure that any exceptions encountered at EL2
> >+ * are handled using the EL2 stack pointer, rather
> >+ * than SP_EL0. */
> >+ msr spsel, #1
> >+
> > /* Rebuild the boot pagetable's first-level entries. The structure
> > * is described in mm.c.
> > *
> >
>
> --
> Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-05-03 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 17:14 [PATCH] xen/arm64: ensure that the correct SP is used for exceptions Kyle Temkin
2016-05-03 10:43 ` Julien Grall
2016-05-03 13:37 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503133747.GL14150@citrix.com \
--to=wei.liu2@citrix.com \
--cc=julien.grall@arm.com \
--cc=ktemkin@binghamton.edu \
--cc=sstabellini@kernel.org \
--cc=temkink@ainfosec.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).